Add deploy task for supported platforms - #28
Conversation
- update packagers: - add deploy functions - replace js2xmlparser with xml2js for bi-directional conversion - refactor getManualOrsayConfData to use xml2js - deploy task for sectv-orsay tested with Orsay (Legacy) Smart TV
Now if you re-deploy an existing widget without deleting it from widgetlist.xml, it will be overwritten instead of being added another time.
| if(fs.existsSync(userConfPath)){ | ||
| var userData = JSON.parse(fs.readFileSync(userConfPath)); | ||
|
|
||
| if(userData.hasOwnProperty('orsay')){ |
There was a problem hiding this comment.
I think there is a typo, it should be 'tizen' I think.
There was a problem hiding this comment.
yeah, you're right.
Thanks for pointing that out.
| if(fs.existsSync(userConfPath)){ | ||
| var userData = JSON.parse(fs.readFileSync(userConfPath)); | ||
|
|
||
| if(userData.hasOwnProperty('orsay')){ |
Correction of typo oversights in: - tasks/packager/sectv-tizen.js - tasks/packager/tv-webos.js
| console.log('\nStart deploying Tizen Samsung Smart TV Platform apps......'); | ||
|
|
||
| var { spawn } = require('child_process'); | ||
| var wgtPath = data.wgtPath || './platform/tizen/build/app.wgt'; |
There was a problem hiding this comment.
the default dest path should be ./platform/sectv-tizen/build/app.wgt
It's sorry for saying that,
There are some parts of this PR that are questionable as to whether it works properly, so It's hard to be accepted for now.
Please test all platforms and make sure that they all work well.
Please consider to attach the working well screenshots for each platforms,
Then I will accept this PR.
There was a problem hiding this comment.
You're right.
As reported, the only tested platform that works so far is Orsay.
I'd say to wait for someone to test the other platforms first.
Thanks for your attention.
2 participants
Uh oh!
There was an error while loading. Please reload this page.