Implementing sid at instrumentation time#132
Open
eliottrobson wants to merge 2 commits intoSamsung:masterfrom
eliottrobson:master
Open
Implementing sid at instrumentation time#132eliottrobson wants to merge 2 commits intoSamsung:masterfrom eliottrobson:master
eliottrobson wants to merge 2 commits intoSamsung:masterfrom
eliottrobson:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation of sids, script ids, these are generated at runtime however because of this there is a bug.
If there are two scripts, script1.js and script2.js, any sid information about any hooks in script1 are lost as soon as script2 is loaded. This change implements the script id at instrumentation time and adds an extra sid parameter to all hooks.
The script enter hook can be used to catch the id and all future calls to any hook within that script will all exhibit the same sid allowing across file tracking. To implement a custom sid it's possible to pass an "thisSid" option to the instrumentCode method.