feat: use overridden ToString for object variable display#227
Open
GustavEikaas wants to merge 1 commit into
Open
feat: use overridden ToString for object variable display#227GustavEikaas wants to merge 1 commit into
GustavEikaas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of my effort to resolve #226 I have identified multiple smaller features needed.
This is the smallest one and a good addition to netcoredbg. In this page https://learn.microsoft.com/en-us/visualstudio/debugger/using-the-debuggerdisplay-attribute?view=visualstudio there is a section quoting
I see that there is an existing function called PrintValue which I left as-is intentionally. This means that if PrintValue modifies the display of any value the overridden ToString will not be respected which IMO is okay. I dont think it would provide any meaningful improvement in display
After this I will continue with
DebuggerDisplayand then the more complexDebuggerBrowsableandDebuggerTypeProxyTested and confirmed locally in sandbox project
System.Guidis a good BCL type for testing with as it is completely unreadable without this PR