Skip to content

Issue #1230: transport/ofi: do not constrain inject_size hint to sizeof(long double) #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcmIntc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Issue #1230: transport/ofi: do not constrain inject_size hint to sizeof(long double) #1231

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d02b81
Temp until Mark pushes this to mainline.
bcmIntc Apr 23, 2026
849816f
transport/ofi: zero max_buffered_send before fi_getinfo hint
bcmIntc May 12, 2026
014aeb8
Revert "Temp until Mark pushes this to mainline."
bcmIntc May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transport_ofi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,9 @@ int query_for_fabric(struct fabric_info *info)
struct fi_fabric_attr fabric_attr = {0};
struct fi_ep_attr ep_attr = {0};

shmem_transport_ofi_max_buffered_send = sizeof(long double);
/* Hint 0 = no minimum inject requirement; provider returns its natural
* inject_size, which is adopted below after fi_getinfo. */
shmem_transport_ofi_max_buffered_send = 0;

@markbrown314 markbrown314 Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


fabric_attr.prov_name = info->prov_name;

Expand Down
Loading