Skip to content

Conversation

@ryandev2
Copy link
Collaborator

See #3

This is an unfinished PR, the abstract SchematicBuilder is basically finished but the individual format builder implementations are yet to be done.
I would like to know if you like this implementation @SandroHc.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Owner

@SandroHc SandroHc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good so far. I suggest you keep the exporters for a later date, as creating an exporter for each format will be a monumental task and it doesn't seem to be required for #3.

@ryandev2 ryandev2 requested a review from SandroHc December 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants