Skip to content

Irwin-Hall and Bates distributions#9

Open
jaksle wants to merge 13 commits intoSantymax98:mainfrom
jaksle:irwin_hall
Open

Irwin-Hall and Bates distributions#9
jaksle wants to merge 13 commits intoSantymax98:mainfrom
jaksle:irwin_hall

Conversation

@jaksle
Copy link

@jaksle jaksle commented Dec 19, 2025

These 2 distributions are nearly the same thing, I slightly generalised the definition from Wikipedia so that this IrwinHall encompasses both.

Copy link
Owner

@Santymax98 Santymax98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you so much for your contribution. I've finished the review and testing... overall, everything is perfect... could you correct or elaborate on that part so I can then integrate it into the main branch? It would only be for large-number security; everything else is OK.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 73.52941% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.33%. Comparing base (360d427) to head (9b2d863).

Files with missing lines Patch % Lines
src/continuous/IrwinHall.jl 70.00% 27 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   69.24%   69.33%   +0.09%     
==========================================
  Files          34       35       +1     
  Lines        1967     2061      +94     
==========================================
+ Hits         1362     1429      +67     
- Misses        605      632      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jaksle
Copy link
Author

jaksle commented Dec 23, 2025

The changes all look good for me :) One small note is I used Roots.Bisection() because Newton method was not stable. Why I don't know, so I might be better to keep it as it is.

I doubt this distribution is of much practical importance, but SciPy has it, Julia should have it. It is a matter of pride ;)

@Santymax98
Copy link
Owner

I understand, perhaps you can use Brent? After this I'll adjust the stability of Lomax and we'll do the merge.

@jaksle
Copy link
Author

jaksle commented Dec 23, 2025

I checked. Roots.Brent and Roots.A42 are stable. Compared to bisection, Brent is around 2x faster. A42 is around 4x faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants