Conversation
Santymax98
left a comment
There was a problem hiding this comment.
Hi, thank you so much for your contribution. I've finished the review and testing... overall, everything is perfect... could you correct or elaborate on that part so I can then integrate it into the main branch? It would only be for large-number security; everything else is OK.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 69.24% 69.33% +0.09%
==========================================
Files 34 35 +1
Lines 1967 2061 +94
==========================================
+ Hits 1362 1429 +67
- Misses 605 632 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The changes all look good for me :) One small note is I used I doubt this distribution is of much practical importance, but SciPy has it, Julia should have it. It is a matter of pride ;) |
|
I understand, perhaps you can use Brent? After this I'll adjust the stability of |
|
I checked. |
These 2 distributions are nearly the same thing, I slightly generalised the definition from Wikipedia so that this
IrwinHallencompasses both.