feature: docker support #450
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was inspired by #442 and decided to rework solution for docker setup (docker only, without CI things).
features:
.envfiletodo:
There few things, which are BLOCKING this MR. Please, DO NOT MERGE until everything done.
issue: broken dump
setup/db_structure.sql:When I tried to load this dump into DB, there were few errors, i went to investigate and researched next:
aowow_articles.quickInfowas removed in DDL, but DML was not changed.aowow_account.allowExpirewas removed in DDL, but DML was not changed.I will create another MR with fix of that later.Another MR with fix of that : fix: database dump ddl/dml inconsistency #452Off topic: my opinion:
warnings/errors during aowow container initialization process (first run)
Probably, it depends on extracted data (i didn't extract it from game data, but i used prepared archive from wow-gaming (thanks, feat(docker): add pipeline and docker support #442))
but i got some warning on setup, it requires some research to understand why they occurred.
Example of warnings & errors
feature: Built data saved to independent volume
issue: Too many images are 404
issue: JavaScript error on each page (alert with text
could not fetch static data: item-scaling)testing:
enhancement: code cleanup
... Further roadmap:
I have managed to make it work, but I feel like it still needs a bit of touch to become finally finished.
What do you think ?
P.S.
I remember this project when I was young (it was in 2010x), and this project is GOLD.
I'm glad to see it's alive. Huge thanks to @Sarjuuk and maintainers for your job. You are awesome.