select the maximal available resolution using a dependecy property#85
Open
rgherzog wants to merge 1 commit intoSascha-L:masterfrom
Open
select the maximal available resolution using a dependecy property#85rgherzog wants to merge 1 commit intoSascha-L:masterfrom
rgherzog wants to merge 1 commit intoSascha-L:masterfrom
Conversation
|
Does not work. When I loop through the result of all resolutions, max value is far far from what the camera supports. For example testing it on tables I get 1280x720 as max value, but the camera goes up to 2560x1440. Also I noticed a significant drop in quality compared to OpenCv wrappers. While images saved are in KB (200-300), with other libraries using same resolution brings about 1.5MB size picture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying the desired width and height only works if the specified values correspond with available resolutions on the selected camera device. If the camera device doesn't support the specified desired width and height "any" resolution is taken; certainly not always the heighest availabe resolution.
This pull request provides a solution that selectes the highest available resolution. This option can be activated using a DependecyProperty in the VideoCaptureElement.
I just used a code-snipped from stackoverflow (https://stackoverflow.com/questions/7497559/how-to-list-camera-available-video-resolution) and included it in VideoCaptureElement. It would bossibly better fit into the VideoCapturePlayer class where it gets used in the SetVideoCaptureParameters method. But this method doesn't work there; the determined sourceFilter remains null.
Unfortunately I know too little about Direct3D to provide a proper solution; but still, I wanted to share my changes with you.