Rename a varialbe to avoid confusion and fix a comment typo#1276
Open
th3or14 wants to merge 1 commit into
Open
Rename a varialbe to avoid confusion and fix a comment typo#1276th3or14 wants to merge 1 commit into
th3or14 wants to merge 1 commit into
Conversation
th3or14
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed changes are for the screenshot example.
I wondered why
copyCmdis used for both copying and blitting. Such variable name gave me a wrong impression that copying is used in the blitting case. ButcopyCmdis just a command buffer used in both cases. I think it's better to rename to something likecmdBufferto avoid confusion. Since there is alreadycmdBufferfrom another scope yet in the same file used insidebuildCommandBuffer(), I suggesttransferCmdBuffer.Change
datetodatain the comment// Getting the image date directly from a swapchain image wouldn't work as they're usually stored in an implementation dependent optimal tiling format.