waiting for alert message after host delete

[amolpati30]

This test tests.foreman.ui.test_computeresource_azurerm.test_positive_end_to_end_azurerm_ft_host_provision is inconsistent — it passes sometimes and fails other times. In Azure, deleting a host take some time, so I'm adding a check to look for the 'delete' message to avoid failures.

Summary by Sourcery

Add explicit wait for the success alert message after deleting a host to prevent intermittent test failures

Bug Fixes:

• Fix intermittent test failures in host deletion by waiting for the deletion success alert

Enhancements:

• Introduce a wait_for wrapper with a 120-second timeout to assert the delete confirmation message

[sourcery-ai]

Reviewer's Guide

The PR enhances the host deletion flow by introducing an explicit wait for the 'Successfully deleted' flash message with a 120-second timeout to address timing inconsistencies in Azure.

Sequence diagram for updated host deletion flow

sequenceDiagram
    actor Tester
    participant HostEntity as Host Entity
    participant View as UI View
    participant Browser
    Tester->>HostEntity: delete(entity_name)
    HostEntity->>View: search(entity_name)
    HostEntity->>View: table.row(name=entity_name)['Actions'].widget.fill('Delete')
    HostEntity->>Browser: handle_alert()
    HostEntity->>View: wait_for(flash.assert_message('Successfully deleted ...'), timeout=120)
    HostEntity->>View: flash.assert_no_error()
    HostEntity->>View: flash.dismiss()

Loading

File-Level Changes

Change	Details	Files
Wait for deletion success alert before proceeding in host.delete	Inserted wait_for lambda to poll for the 'Successfully deleted {entity_name}' flash message Set timeout to 120 seconds to accommodate Azure host deletion delays	airgun/entities/host.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @amolpati30 - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_azurerm.py -k test_positive_end_to_end_azurerm_ft_host_provision

[sambible]

Seems reasonable, but these always look like reasonable changes on paper, if PRT proves it out I'm fine with merging.

[LadislavVasina1]

ACK, @amolpati30 keep an eye on the automation results too