search button not getting clicked on activation key page due to different locator

[jnagare-redhat]

Summary:
Search button not getting clicked on activation key page due to different locator
Reason:

• We have search button on activation key page
• But other pages have search arrow and currently we are using locator of search arrow Fix :
• We can add locator with or condition to avoid breaking existing test cases
• PF5Button(locator=".//button[@aria-label='Search'] | .//button[span[normalize-space(.)='Search']]")

Summary by Sourcery

Fix search button locator to support both activation key and other pages and ensure activation key view is displayed before interaction

Bug Fixes:

• Correct search button locator in Search widget to handle activation key page button

Enhancements:

• Add view.wait_displayed() in ActivationKeyEntity.create to wait for the view before filling values

[sourcery-ai]

Reviewer's Guide

This PR enhances the search button locator to support both activation key and other pages without breaking existing tests, and adds a wait step to the activation key creation workflow to ensure the form is ready before interaction.

Sequence diagram for activation key creation with wait step

sequenceDiagram
    actor Tester
    participant ActivationKeyEntity
    participant View
    Tester->>ActivationKeyEntity: create(values)
    ActivationKeyEntity->>View: navigate_to('New')
    ActivationKeyEntity->>View: wait_displayed()
    ActivationKeyEntity->>View: fill(values)
    ActivationKeyEntity->>View: submit.click()

Loading

Class diagram for updated Search widget and ActivationKeyEntity

classDiagram
    class Search {
        +PF5Button search_button
        +Text clear_button
    }
    class PF5Button {
        +locator
    }
    class ActivationKeyEntity {
        +create(values)
    }
    Search --> PF5Button : uses
    ActivationKeyEntity --> "1" View : uses
    class View {
        +wait_displayed()
        +fill(values)
        +submit
    }

Loading

File-Level Changes

Change	Details	Files
Broadened search button locator to match both span-based and aria-label-based buttons	Replaced locator string with an or-condition combining span text and aria-label selectors	airgun/widgets.py
Added synchronization before interacting with the activation key creation view	Inserted view.wait_displayed() immediately after navigation to the 'New' activation key view	airgun/entities/activationkey.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @jnagare-redhat - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jnagare-redhat]

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k test_positive_create_with_cv

[jnagare-redhat]

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k test_positive_create_with_cv

[LadislavVasina1]

ACK, good addition @jnagare-redhat!