Skip to content

Change Owner Fixes - #1940

Merged
LadislavVasina1 merged 1 commit into
SatelliteQE:masterfrom
LadislavVasina1:ChangeOwnerFixes
Aug 4, 2025
Merged

Change Owner Fixes#1940
LadislavVasina1 merged 1 commit into
SatelliteQE:masterfrom
LadislavVasina1:ChangeOwnerFixes

Conversation

@LadislavVasina1

@LadislavVasina1 LadislavVasina1 commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Navigation to the owner change action changed a little bit.
This PR fixes this.
Needed by: SatelliteQE/robottelo#19106

Summary by Sourcery

Fix bulk action navigation for changing hosts owner and location to match updated 'Change associations' submenu UI.

Bug Fixes:

  • Adjust change_hosts_owner to hover over 'Change associations' submenu before selecting 'Owner'
  • Update change_associations_location to hover over 'Change associations' submenu before selecting 'Location'

@LadislavVasina1
LadislavVasina1 requested a review from vsedmik August 4, 2025 08:14
@LadislavVasina1 LadislavVasina1 self-assigned this Aug 4, 2025
@LadislavVasina1 LadislavVasina1 added No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Aug 4, 2025
@sourcery-ai

sourcery-ai Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adapt bulk action workflows for owner and location updates to align with UI changes grouping them under the “Change associations” submenu by adjusting menu navigation calls accordingly.

Sequence diagram for updated owner change workflow

sequenceDiagram
    actor User
    participant AllHostsPage
    participant BulkActionsMenu
    participant ChangeAssociationsMenu
    participant ChangeHostsOwnerModal

    User->>AllHostsPage: Initiate change_hosts_owner(host_names, new_owner_name)
    AllHostsPage->>BulkActionsMenu: Click bulk_actions_kebab
    AllHostsPage->>BulkActionsMenu: move_to_element('Change associations')
    BulkActionsMenu->>ChangeAssociationsMenu: Open submenu
    ChangeAssociationsMenu->>ChangeAssociationsMenu: item_select('Owner')
    AllHostsPage->>ChangeHostsOwnerModal: Open modal
    ChangeHostsOwnerModal->>ChangeHostsOwnerModal: owner_select.item_select(new_owner_name)
    ChangeHostsOwnerModal->>AllHostsPage: Confirm owner change
Loading

Sequence diagram for updated location change workflow

sequenceDiagram
    actor User
    participant AllHostsPage
    participant BulkActionsMenu
    participant ChangeAssociationsMenu
    participant ChangeLocationModal

    User->>AllHostsPage: Initiate change_associations_location(host_names, new_location)
    AllHostsPage->>BulkActionsMenu: Click bulk_actions_kebab
    AllHostsPage->>BulkActionsMenu: move_to_element('Change associations')
    BulkActionsMenu->>ChangeAssociationsMenu: Open submenu
    ChangeAssociationsMenu->>ChangeAssociationsMenu: item_select('Location')
    AllHostsPage->>ChangeLocationModal: Open modal
    ChangeLocationModal->>ChangeLocationModal: location_menu.item_select(new_location)
    ChangeLocationModal->>AllHostsPage: Confirm location change
Loading

File-Level Changes

Change Details Files
Update owner change action to use “Change associations” submenu
  • Replace direct selection of “Change owner” with move_to_element() on “Change associations”
  • Select “Owner” from the new associations submenu before opening the owner modal
airgun/entities/all_hosts.py
Update location change action to use “Change associations” submenu
  • Insert move_to_element() call to target “Change associations” before selecting “Location”
  • Ensure selection of “Location” submenu leads into the location modal
airgun/entities/all_hosts.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LadislavVasina1 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LadislavVasina1

Copy link
Copy Markdown
Contributor Author

PRT passed in SatelliteQE/robottelo#19106

@LadislavVasina1 LadislavVasina1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Aug 4, 2025

@pnovotny pnovotny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@LadislavVasina1
LadislavVasina1 merged commit 185b77e into SatelliteQE:master Aug 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants