PF5 updates for host detail Content: Errata & Module streams tabs - #1941
Conversation
Reviewer's GuideThis PR migrates the host detail Content Errata and Module Streams tabs from PF4 to PF5 by swapping out legacy selector, dropdown, table, and pagination components for their PF5 OUIA equivalents. Class diagram for updated PF5 widgets in host detail Content: Errata & Module streams tabsclassDiagram
class errata {
+Checkbox select_all
+SearchInput searchbar
+PF5OUIASelect type_filter
+PF5OUIASelect severity_filter
+PF5Dropdown dropdown
+MenuToggleButtonMenu kebab_actions
+PF5OUIAExpandableTable table
+PF5Pagination pagination
}
class module_streams {
+SearchInput searchbar
+PF5OUIASelect status_filter
+PF5OUIASelect installation_status_filter
+PF5Dropdown dropdown
+MenuToggleButtonMenu kebab_actions
+PF5OUIATable table
+PF5Pagination pagination
}
errata --|> PF5Tab
module_streams --|> PF5Tab
PF5OUIAExpandableTable <|-- PF5OUIATable
PF5Dropdown <.. MenuToggleButtonMenu : uses
PF5OUIASelect <.. PF5OUIAExpandableTable : used in filters
PF5OUIASelect <.. PF5OUIATable : used in filters
PF5Pagination <.. PF5OUIAExpandableTable : used for pagination
PF5Pagination <.. PF5OUIATable : used for pagination
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
This PR is basically an updated version of #1888 |
|
trigger: test-robottelo |
There was a problem hiding this comment.
Hey @pnovotny - I've reviewed your changes - here's some feedback:
- The errata tab still uses Pf4ActionsDropdown; consider migrating it to a PF5 action menu equivalent to complete the PF4->PF5 transition.
- Several PF5OUIASelect filters follow the same pattern—extraction into a small factory/helper could reduce duplication.
- PF5Dropdown is initialized with a raw locator while PF5OUIASelect uses component_id; standardizing on component_id-driven instantiation would better align with OUIA practices.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The errata tab still uses Pf4ActionsDropdown; consider migrating it to a PF5 action menu equivalent to complete the PF4->PF5 transition.
- Several PF5OUIASelect filters follow the same pattern—extraction into a small factory/helper could reduce duplication.
- PF5Dropdown is initialized with a raw locator while PF5OUIASelect uses component_id; standardizing on component_id-driven instantiation would better align with OUIA practices.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@pnovotny Could you please look into the PRT results |
Both tests failed at the beginning on |
|
trigger: test-robottelo |
Updated PF5 widgets on host detail Content: Errata & Module streams tabs. Also: Most customized locators in `MenuToggleButtonMenu` widget were removed, because they were including only dropdown toggle variant and not menu toggle one. Original locators include both variants which should suffice. The default locator now includes also common kebab menu aria labels so it doesn't need to be supplied as an init parameter for each instance.
96fae39 to
7ca92ac
Compare
|
Running PRTs in the dependent robottelo PR SatelliteQE/robottelo#19146 |
Updated PF5 widgets on host detail Content: Errata & Module streams tabs. Also: Most customized locators in `MenuToggleButtonMenu` widget were removed, because they were including only dropdown toggle variant and not menu toggle one. Original locators include both variants which should suffice. The default locator now includes also common kebab menu aria labels so it doesn't need to be supplied as an init parameter for each instance.
Host Content Errata & Module streams PF5 updates
Updated PF5 widgets on host detail - Content - Errata & Module streams tabs.
Summary by Sourcery
Upgrade host detail errata and module streams tabs to use PF5 OUIA-compliant widgets for filters, dropdowns, tables, and pagination.
Enhancements: