Skip to content

Add upper bound for Patternfly libraries #1 - #2058

Merged
vsedmik merged 1 commit into
SatelliteQE:masterfrom
LadislavVasina1:AddUpperBoundForPatternflyLibs
Sep 25, 2025
Merged

Add upper bound for Patternfly libraries #1#2058
vsedmik merged 1 commit into
SatelliteQE:masterfrom
LadislavVasina1:AddUpperBoundForPatternflyLibs

Conversation

@LadislavVasina1

Copy link
Copy Markdown
Contributor

This PR is a follow-up for this PR #2050 which limited widgetastic.core version.
Here we add an upper bound for the next major version of widgetastic.patterfly... libraries.

6.17.z, 6.16.z, 6.15.z will need its own PR without widgetastic.patterfly5 line.

@LadislavVasina1 LadislavVasina1 self-assigned this Sep 24, 2025
@LadislavVasina1 LadislavVasina1 added CherryPick PR needs CherryPick to previous branches Stream 6.18.z labels Sep 24, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread setup.py
'widgetastic.patternfly5',
'widgetastic.patternfly<2.0',
'widgetastic.patternfly4<2.0',
'widgetastic.patternfly5<26.0',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suddenly I regret switching to date based versioning.

This won't hurt, but won't necessarily protect you.

I'll be in touch for the specific version you'll want to pin before we release any breaking changes in wt.pf5

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks @mshriver

@vsedmik vsedmik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, please take care of the remaining CPs @LadislavVasina1

@vsedmik
vsedmik merged commit f15cb18 into SatelliteQE:master Sep 25, 2025
11 checks passed
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2025
vsedmik pushed a commit that referenced this pull request Sep 25, 2025
(cherry picked from commit f15cb18)

Co-authored-by: Ladislav Vašina <lvasina@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.18.z CherryPick PR needs CherryPick to previous branches Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants