[6.18.z] read recommended repositories by it types - #2066
Merged
sambible merged 1 commit intoOct 31, 2025
Conversation
(cherry picked from commit d4bd8c1)
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `airgun/entities/redhat_repository.py:24` </location>
<code_context>
return view.search(value, category=category, types=types)
- def read(self, entity_name=None, category='Available', recommended_repo=None):
+ def read(self, entity_name=None, category='Available', recommended_repo=None, filter_type=None):
"""Read RH Repositories values.
</code_context>
<issue_to_address>
**nitpick:** The new filter_type parameter is added but not documented in the function docstring.
Please specify the valid values for filter_type and describe its impact on the repository search in the docstring.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| return view.search(value, category=category, types=types) | ||
|
|
||
| def read(self, entity_name=None, category='Available', recommended_repo=None): | ||
| def read(self, entity_name=None, category='Available', recommended_repo=None, filter_type=None): |
Contributor
There was a problem hiding this comment.
nitpick: The new filter_type parameter is added but not documented in the function docstring.
Please specify the valid values for filter_type and describe its impact on the repository search in the docstring.
vijaysawant
approved these changes
Oct 31, 2025
damoore044
approved these changes
Oct 31, 2025
sambible
approved these changes
Oct 31, 2025
Gauravtalreja1
deleted the
cherry-pick-6.18.z-d4bd8c1e91f59103c8a55153bdb7e8a4365db039
branch
February 3, 2026 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #2049
Problem Statement
No support presented for
recommended kickstart repositoriesin airgun entities & in views.Solution
Update
RedHatRepositoryEntityread method andRedHatRepositoriesViewwith required changes.Related robottelo PR
SatelliteQE/robottelo#19676