Skip to content

[6.18.z] read recommended repositories by it types - #2066

Merged
sambible merged 1 commit into
6.18.zfrom
cherry-pick-6.18.z-d4bd8c1e91f59103c8a55153bdb7e8a4365db039
Oct 31, 2025
Merged

[6.18.z] read recommended repositories by it types#2066
sambible merged 1 commit into
6.18.zfrom
cherry-pick-6.18.z-d4bd8c1e91f59103c8a55153bdb7e8a4365db039

Conversation

@Satellite-QE

Copy link
Copy Markdown
Contributor

Cherrypick of PR: #2049

Problem Statement
No support presented for recommended kickstart repositories in airgun entities & in views.

Solution
Update RedHatRepositoryEntity read method and RedHatRepositoriesView with required changes.

Related robottelo PR
SatelliteQE/robottelo#19676

@Satellite-QE Satellite-QE added 6.18.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 25, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `airgun/entities/redhat_repository.py:24` </location>
<code_context>
         return view.search(value, category=category, types=types)

-    def read(self, entity_name=None, category='Available', recommended_repo=None):
+    def read(self, entity_name=None, category='Available', recommended_repo=None, filter_type=None):
         """Read RH Repositories values.

</code_context>

<issue_to_address>
**nitpick:** The new filter_type parameter is added but not documented in the function docstring.

Please specify the valid values for filter_type and describe its impact on the repository search in the docstring.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

return view.search(value, category=category, types=types)

def read(self, entity_name=None, category='Available', recommended_repo=None):
def read(self, entity_name=None, category='Available', recommended_repo=None, filter_type=None):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: The new filter_type parameter is added but not documented in the function docstring.

Please specify the valid values for filter_type and describe its impact on the repository search in the docstring.

@sambible
sambible merged commit 251cdd9 into 6.18.z Oct 31, 2025
14 checks passed
@Gauravtalreja1
Gauravtalreja1 deleted the cherry-pick-6.18.z-d4bd8c1e91f59103c8a55153bdb7e8a4365db039 branch February 3, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.18.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants