[6.18.z] Add Get Host Create View Entity - #2325
Merged
LadislavVasina1 merged 1 commit intoFeb 26, 2026
Merged
Conversation
(cherry picked from commit f6c3167)
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
get_create_formduplicates the navigation logic already present increate; consider refactoringcreateto callget_create_formso the flow for reaching the New Host page is defined in a single place. - The method name
get_create_formand its docstring (Return HostCreateView) are slightly inconsistent with what’s returned (a view object); consider renaming toget_create_viewor adjusting the docstring to better reflect its purpose.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `get_create_form` duplicates the navigation logic already present in `create`; consider refactoring `create` to call `get_create_form` so the flow for reaching the New Host page is defined in a single place.
- The method name `get_create_form` and its docstring (`Return HostCreateView`) are slightly inconsistent with what’s returned (a view object); consider renaming to `get_create_view` or adjusting the docstring to better reflect its purpose.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LadislavVasina1
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #2323
Needed by: SatelliteQE/robottelo#20888 (PRT ran and passed here)