Skip to content

[6.18.z] Add Get Host Create View Entity - #2325

Merged
LadislavVasina1 merged 1 commit into
6.18.zfrom
cherry-pick-6.18.z-f6c3167c35c3257ee2fe18f64a35b4137d7c38ca
Feb 26, 2026
Merged

[6.18.z] Add Get Host Create View Entity#2325
LadislavVasina1 merged 1 commit into
6.18.zfrom
cherry-pick-6.18.z-f6c3167c35c3257ee2fe18f64a35b4137d7c38ca

Conversation

@Satellite-QE

Copy link
Copy Markdown
Contributor

Cherrypick of PR: #2323

Needed by: SatelliteQE/robottelo#20888 (PRT ran and passed here)

(cherry picked from commit f6c3167)
@Satellite-QE Satellite-QE self-assigned this Feb 26, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new get_create_form duplicates the navigation logic already present in create; consider refactoring create to call get_create_form so the flow for reaching the New Host page is defined in a single place.
  • The method name get_create_form and its docstring (Return HostCreateView) are slightly inconsistent with what’s returned (a view object); consider renaming to get_create_view or adjusting the docstring to better reflect its purpose.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `get_create_form` duplicates the navigation logic already present in `create`; consider refactoring `create` to call `get_create_form` so the flow for reaching the New Host page is defined in a single place.
- The method name `get_create_form` and its docstring (`Return HostCreateView`) are slightly inconsistent with what’s returned (a view object); consider renaming to `get_create_view` or adjusting the docstring to better reflect its purpose.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LadislavVasina1 LadislavVasina1 added No-CherryPick PR doesnt need CherryPick to previous branches 6.18.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR labels Feb 26, 2026
@LadislavVasina1
LadislavVasina1 merged commit 60a54ff into 6.18.z Feb 26, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.18.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants