SAT-45979 errata sync status - #2485
Merged
sambible merged 1 commit intoJul 22, 2026
Merged
Conversation
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The docstring parameter annotations for
search_repositoriesare slightly off (:param str optional lce:/cv:); consider using the standard Sphinx style (e.g.,:param str lce:) and describing the optionality in the text to keep generated docs and IDE hints clean. - For consistency and readability, consider using more descriptive parameter names than
lceandcv(e.g.,lifecycle_envandcontent_view), matching any existing naming conventions for these concepts elsewhere in the codebase.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The docstring parameter annotations for `search_repositories` are slightly off (`:param str optional lce:` / `cv:`); consider using the standard Sphinx style (e.g., `:param str lce:`) and describing the optionality in the text to keep generated docs and IDE hints clean.
- For consistency and readability, consider using more descriptive parameter names than `lce` and `cv` (e.g., `lifecycle_env` and `content_view`), matching any existing naming conventions for these concepts elsewhere in the codebase.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LadislavVasina1
approved these changes
Jul 22, 2026
sambible
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add search_repositories method to ErrataEntity to support filtering errata repositories by lifecycle environment and content view. This enables UI test coverage for SAT-45979, which verifies errata sync status is correctly displayed across content views.
Robottelo PR SatelliteQE/robottelo#22196