Skip to content

Add cacert text input field to ldap auth source view - #2486

Open
adamruzicka wants to merge 2 commits into
SatelliteQE:masterfrom
adamruzicka:ldap-cacert
Open

Add cacert text input field to ldap auth source view#2486
adamruzicka wants to merge 2 commits into
SatelliteQE:masterfrom
adamruzicka:ldap-cacert

Conversation

@adamruzicka

Copy link
Copy Markdown
Contributor

theforeman/foreman#11107 adds a cacert attribute to ldap auth servers. This extends the ldap authentication create view with the new input field.

@adamruzicka adamruzicka added view Issues related to Views coverage No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Jul 22, 2026
@adamruzicka
adamruzicka marked this pull request as ready for review July 28, 2026 10:53

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@adamruzicka

Copy link
Copy Markdown
Contributor Author

Let's hold it until the changes in foreman actually go in.

@adamruzicka

Copy link
Copy Markdown
Contributor Author

Includes #2490

@jnagare-redhat jnagare-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches Stream view Issues related to Views coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants