Fix Create Host button locator for new UI empty state - #2494
Open
nacoool wants to merge 1 commit into
Open
Conversation
Contributor
|
This feels like a bug to me, I dont really like this particular ID rename, could you check that please @nacoool |
nacoool
added
6.19.z
No-CherryPick
stejskalleos
requested changes
Aug 4, 2026
Comment on lines
+231
to
+237
| new = Text( | ||
| ".//div[@id='foreman-page']//a[" | ||
| "@data-ouia-component-id='create-host-button' or " | ||
| "(@data-ouia-component-id='empty-state-secondary-action-button' " | ||
| "and normalize-space(.)='Create Host')" | ||
| "]" | ||
| ) |
There was a problem hiding this comment.
Why not just
Suggested change
| new = Text( | |
| ".//div[@id='foreman-page']//a[" | |
| "@data-ouia-component-id='create-host-button' or " | |
| "(@data-ouia-component-id='empty-state-secondary-action-button' " | |
| "and normalize-space(.)='Create Host')" | |
| "]" | |
| ) | |
| new = Text( | |
| ".//a[" | |
| "@data-ouia-component-id='create-host-button' or " | |
| "@data-ouia-component-id='empty-state-secondary-action-button' "" | |
| "]" | |
| ) |
and can we use better naming than new? Specially when there is a new_ui_button down there :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Hosts page empty state uses OUIA ID
'empty-state-secondary-action-button' instead of 'create-host-button'.
Update the XPath to match either ID, with text filtering to distinguish
Create Host from Register Host which shares the same OUIA ID.