Skip to content

Update VMware image-based provisioning test to cover SAT-30594 #18368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shubhamsg199 merged 1 commit into from
May 28, 2025
Merged

Update VMware image-based provisioning test to cover SAT-30594 #18368

shubhamsg199 merged 1 commit into from
May 28, 2025

Conversation

@Gauravtalreja1
Copy link
Member

@Gauravtalreja1 Gauravtalreja1 commented May 5, 2025

Problem Statement

vTPM option doesn't work for VMware image-based provisioning, and SAT-30594 fixes this issue

Solution

Update existing VMware image-based provisioning test to cover SAT-30594

Dependant PRs

theforeman/foreman#10524
fog/fog-vsphere#309

@Gauravtalreja1 Gauravtalreja1 self-assigned this May 5, 2025
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner May 5, 2025 19:39
@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels May 5, 2025
chris1984
chris1984 approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 6, 2025 

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true
theforeman:
    foreman: 10524

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 6, 2025

PRT Result

Build Number: 11297
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 14 deselected, 40 warnings in 2539.33s (0:42:19) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 6, 2025
@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 7, 2025 

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true
theforeman:
    foreman: 10524

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 7, 2025

PRT Result

Build Number: 11311
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 14 deselected, 30 warnings, 2 errors in 1667.82s (0:27:47) ==========

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 7, 2025

PRT Result

Build Number: 11317
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 14 deselected, 41 warnings in 2294.29s (0:38:14) ==========

@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 16, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 16, 2025

PRT Result

Build Number: 11391
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 14 deselected, 37 warnings in 2091.85s (0:34:51) ==========

nofaralfasi
nofaralfasi reviewed May 18, 2025
View reviewed changes
Copy link

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@chris1984
Copy link
Member

chris1984 commented May 18, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 18, 2025

PRT Result

Build Number: 11401
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 14 deselected, 37 warnings in 2060.00s (0:34:20) ==========

@Gauravtalreja1 Gauravtalreja1 force-pushed the vtpm-image-based-prov branch from 6c76c3f to 7fdaf7a Compare May 18, 2025 20:54
@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 18, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 18, 2025

PRT Result

Build Number: 11402
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 14 deselected, 37 warnings in 2129.98s (0:35:29) ==========

@Gauravtalreja1 Gauravtalreja1 force-pushed the vtpm-image-based-prov branch 2 times, most recently from 644fd8a to 2fc319e Compare May 18, 2025 21:47
@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 18, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 18, 2025

PRT Result

Build Number: 11403
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ===== 1 failed, 1 passed, 14 deselected, 37 warnings in 2374.26s (0:39:34) =====

@shubhamsg199
Copy link
Contributor

shubhamsg199 commented May 19, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py::test_positive_image_provision_end_to_end[rhel8-ipv4-vmware7-destroy_vm_on_host_delete=True]
provisioning: true

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 19, 2025

PRT Result

Build Number: 11407
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py::test_positive_image_provision_end_to_end[rhel8-ipv4-vmware7-destroy_vm_on_host_delete=True] --external-logging --include-onprem-provisioning
Test Result : ================== 1 failed, 9 warnings in 2336.19s (0:38:56) ==================

@shubhamsg199
Copy link
Contributor

shubhamsg199 commented May 21, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 21, 2025

PRT Result

Build Number: 11447
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ===== 1 failed, 1 passed, 14 deselected, 37 warnings in 2100.01s (0:35:00) =====

@shubhamsg199
Copy link
Contributor

shubhamsg199 commented May 21, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE May 21, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE May 21, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE May 21, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE May 21, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE May 21, 2025
@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 21, 2025

PRT Result

Build Number: 11455
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ===== 1 failed, 1 passed, 14 deselected, 38 warnings in 2260.98s (0:37:40) =====

@Gauravtalreja1 Gauravtalreja1 force-pushed the vtpm-image-based-prov branch from 2fc319e to 4c3ddae Compare May 26, 2025 21:51
@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 26, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE May 27, 2025
@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 27, 2025

PRT Result

Build Number: 11490
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 14 deselected, 29 warnings, 2 errors in 1666.08s (0:27:46) ==========

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented May 27, 2025

PRT Result

Build Number: 11494
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ===== 1 failed, 1 passed, 14 deselected, 38 warnings in 2278.92s (0:37:58) =====

@Gauravtalreja1
Copy link
Member Author

Gauravtalreja1 commented May 27, 2025

PRT failure with vCenter7 looks like a configuration issue and @shubhamsg199 is investigating it, so I'll say this PR now is ready for review and can be merged when approved

@shubhamsg199 shubhamsg199 merged commit 7226daf into SatelliteQE:master May 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nofaralfasi nofaralfasi nofaralfasi left review comments

@chris1984 chris1984 chris1984 approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels

No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gauravtalreja1 @Satellite-QE @chris1984 @shubhamsg199 @nofaralfasi