Fix ACS IPv6 tests with ACS HTTP proxy - #18767
Merged
Merged
Conversation
Contributor
Author
|
Collaborator
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
Contributor
Author
|
LadislavVasina1
approved these changes
Jun 18, 2025
LadislavVasina1
left a comment
LadislavVasina1
left a comment
Contributor
There was a problem hiding this comment.
ACK, pending PRT
Collaborator
|
PRT Result |
|
|
||
| # In case of IPv6, set 'ACS HTTP proxy' of the bound capsule to the IPv6 proxy | ||
| # This is necessary for the Refresh to succeed. | ||
| if not settings.server.network_type.has_ipv4: |
Member
There was a problem hiding this comment.
Suggested change
| if not settings.server.network_type.has_ipv4: | |
| if settings.server.network_type.has_ipv6: |
Contributor
Author
There was a problem hiding this comment.
NACK, this does not translate the same.
not settings.server.network_type.has_ipv4 => renders to "anything that does not have IPv4" => IPv6 only at the moment, but can be any future version lacking IPv4.
settings.server.network_type.has_ipv6 => renders to "anything that has IPv6" => IPv6 and dualstack at the moment. We don't need this fix for dualstack since it has the IPv4 connectivity.
|
|
||
| # In case of IPv6, set 'ACS HTTP proxy' of the bound capsule to the IPv6 proxy | ||
| # This is necessary for the Refresh to succeed. | ||
| if not settings.server.network_type.has_ipv4: |
Member
There was a problem hiding this comment.
Suggested change
| if not settings.server.network_type.has_ipv4: | |
| if settings.server.network_type.has_ipv6: |
sambible
approved these changes
Jun 18, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
(cherry picked from commit 3fa840f)
Gauravtalreja1
pushed a commit
that referenced
this pull request
Jun 18, 2025
damoore044
pushed a commit
that referenced
this pull request
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Some ACS tests (those running Refresh) fail in IPv6 pipeline since they can't reach out to the IPv4 source, because ACSes have the HTTP proxy set separately for the capsule they are using.
Solution
Set the ACS HTTP proxy on the Capsule used by ACS to the IPv6 proxy and create the ACS with
use_http_proxiesoption.Related Issues
https://issues.redhat.com/browse/SAT-34801
Requires SatelliteQE/nailgun#1314
PRT test Cases example