Two Settings UI test fixes - #19043
Merged
Merged
Conversation
lhellebr
added
CherryPick
lhellebr
changed the title
lhellebr
changed the title
Contributor
Author
|
PRT passed in SatelliteQE/airgun#1934 |
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
The settings field contains "Version $VERSION" and $VERSION should be replaced by actual version, e.g. 6.18.0. When the test compares "Version $VERSION" - the content of the field - with the actually shown footer text, it fails. For some mysterious reason not yet known to me, the test sometimes got actual text "Version 6.18.0" instead of the unexpanded variable so this actually passed pre-6.18. I don't understand, but this fix should work for both cases. The test somehow presumes the original value to be Yes, even though it doesn't need to be. Fixed. (cherry picked from commit cad72c1)
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
The settings field contains "Version $VERSION" and $VERSION should be replaced by actual version, e.g. 6.18.0. When the test compares "Version $VERSION" - the content of the field - with the actually shown footer text, it fails. For some mysterious reason not yet known to me, the test sometimes got actual text "Version 6.18.0" instead of the unexpanded variable so this actually passed pre-6.18. I don't understand, but this fix should work for both cases. The test somehow presumes the original value to be Yes, even though it doesn't need to be. Fixed. (cherry picked from commit cad72c1)
This was referenced Jul 31, 2025
pondrejk
pushed a commit
that referenced
this pull request
Oct 7, 2025
Two Settings UI test fixes (#19043) The settings field contains "Version $VERSION" and $VERSION should be replaced by actual version, e.g. 6.18.0. When the test compares "Version $VERSION" - the content of the field - with the actually shown footer text, it fails. For some mysterious reason not yet known to me, the test sometimes got actual text "Version 6.18.0" instead of the unexpanded variable so this actually passed pre-6.18. I don't understand, but this fix should work for both cases. The test somehow presumes the original value to be Yes, even though it doesn't need to be. Fixed. (cherry picked from commit cad72c1) Co-authored-by: Lukáš Hellebrandt <lhellebr@redhat.com>
pondrejk
pushed a commit
that referenced
this pull request
Oct 7, 2025
Two Settings UI test fixes (#19043) The settings field contains "Version $VERSION" and $VERSION should be replaced by actual version, e.g. 6.18.0. When the test compares "Version $VERSION" - the content of the field - with the actually shown footer text, it fails. For some mysterious reason not yet known to me, the test sometimes got actual text "Version 6.18.0" instead of the unexpanded variable so this actually passed pre-6.18. I don't understand, but this fix should work for both cases. The test somehow presumes the original value to be Yes, even though it doesn't need to be. Fixed. (cherry picked from commit cad72c1) Co-authored-by: Lukáš Hellebrandt <lhellebr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings field contains "Version $VERSION" and $VERSION should be replaced by actual version, e.g. 6.18.0. When the test compares "Version $VERSION" - the content of the field - with the actually shown footer text, it fails.
For some mysterious reason not yet known to me, the test sometimes got actual text "Version 6.18.0" instead of the unexpanded variable so this actually passed pre-6.18. I don't understand, but this fix should work for both cases.
The test somehow presumes the original value to be Yes, even though it doesn't need to be. Fixed.