Skip to content

Two Settings UI test fixes #19043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pnovotny merged 2 commits into from
Jul 31, 2025
Merged

Two Settings UI test fixes #19043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3edd4f3
Replace by actual version when comparing strings.
lhellebr Jul 23, 2025
859b1c5
Test with hardcoded Yes first, then finally reset to default
lhellebr Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions tests/foreman/ui/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import pytest

from robottelo.config import settings
from robottelo.hosts import get_sat_version
from robottelo.utils.datafactory import filtered_datapoint, gen_string


Expand Down Expand Up @@ -228,7 +229,9 @@ def test_positive_update_login_page_footer_text(session, setting_update):
session.login.login(login_details)
session.settings.update(f'name = {property_name}', default_value)
result = session.login.logout()
assert result["login_text"] == default_value
sat_version = get_sat_version()
default_value_with_version_expanded = default_value.replace('$VERSION', str(sat_version))
assert result["login_text"] == default_value_with_version_expanded

# set empty
session.login.login(login_details)
Expand Down Expand Up @@ -531,21 +534,28 @@ def test_positive_setting_display_fqdn_for_hosts(session, target_sat):
"""
host_name, domain_name = target_sat.hostname.split('.', 1)
default_value = target_sat.update_setting('display_fqdn_for_hosts', 'No')
with target_sat.ui_session() as session:
dashboard_hosts = session.dashboard.read('NewHosts')
assert host_name in [h['Host'] for h in dashboard_hosts['hosts'] if h['Host'] == host_name]

values = session.host_new.get_details(host_name, widget_names='breadcrumb')
assert values['breadcrumb'] == host_name

# Verify with display_fqdn_for_hosts=Yes
try:
with target_sat.ui_session() as session:
dashboard_hosts = session.dashboard.read('NewHosts')
assert host_name in [
h['Host'] for h in dashboard_hosts['hosts'] if h['Host'] == host_name
]

values = session.host_new.get_details(host_name, widget_names='breadcrumb')
assert values['breadcrumb'] == host_name

# Verify with display_fqdn_for_hosts=Yes
target_sat.update_setting('display_fqdn_for_hosts', 'Yes')
full_name = '.'.join((host_name, domain_name))
dashboard_hosts = session.dashboard.read('NewHosts')
assert full_name in [
h['Host'] for h in dashboard_hosts['hosts'] if h['Host'] == full_name
]

values = session.host_new.get_details(target_sat.hostname, widget_names='breadcrumb')
assert values['breadcrumb'] == full_name
finally:
target_sat.update_setting('display_fqdn_for_hosts', default_value)
full_name = '.'.join((host_name, domain_name))
dashboard_hosts = session.dashboard.read('NewHosts')
assert full_name in [h['Host'] for h in dashboard_hosts['hosts'] if h['Host'] == full_name]

values = session.host_new.get_details(target_sat.hostname, widget_names='breadcrumb')
assert values['breadcrumb'] == full_name


def test_positive_show_unsupported_templates(request, target_sat, module_org, module_location):
Expand Down