Skip to content

[6.19.z] adding blockedby to auth tests - #20838

Merged
pondrejk merged 1 commit into
6.19.zfrom
cherry-pick-6.19.z-0f48d298ebf0609940a725fca42a49e50ec09ec1
Feb 23, 2026
Merged

[6.19.z] adding blockedby to auth tests#20838
pondrejk merged 1 commit into
6.19.zfrom
cherry-pick-6.19.z-0f48d298ebf0609940a725fca42a49e50ec09ec1

Conversation

@Satellite-QE

@Satellite-QE Satellite-QE commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

Cherrypick of PR: #20837

Problem Statement

adding blocked by to automation to not pollute the results until the bug is fixed

Solution

Related Issues

Summary by Sourcery

Tests:

  • Annotate affected LDAP authentication tests with a BlockedBy reference to SAT-42705 so they are tracked as blocked until the bug is resolved.

@Satellite-QE Satellite-QE added 6.19.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 23, 2026
@sourcery-ai

sourcery-ai Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Annotates select LDAP authentication UI and destructive tests with a :BlockedBy: SAT-42705 marker so they are treated as blocked while the related bug is unresolved, without changing any test logic or behavior.

File-Level Changes

Change Details Files
Mark specific LDAP authentication UI tests as blocked due to SAT-42705.
  • Add ':BlockedBy: SAT-42705' to the docstring of test_positive_update_external_roles.
  • Add ':BlockedBy: SAT-42705' to the docstring of test_positive_delete_external_roles.
  • Add ':BlockedBy: SAT-42705' to the docstring of test_positive_add_admin_role_with_org_loc.
  • Add ':BlockedBy: SAT-42705' to the docstring of test_verify_group_permissions.
tests/foreman/ui/test_ldap_authentication.py
Mark a destructive LDAP authentication test as blocked due to SAT-42705.
  • Add ':BlockedBy: SAT-42705' to the docstring of test_user_permissions_rhsso_user_multiple_group.
tests/foreman/destructive/test_ldap_authentication.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pondrejk
pondrejk merged commit 4b4427a into 6.19.z Feb 23, 2026
15 checks passed
@pondrejk
pondrejk deleted the cherry-pick-6.19.z-0f48d298ebf0609940a725fca42a49e50ec09ec1 branch February 23, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.19.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants