[6.19.z] CCV auto-publish on child CV minor version publish - #20859
Merged
Satellite-QE merged 1 commit intoFeb 24, 2026
Merged
Conversation
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED (cherry picked from commit 5ca9326)
Collaborator
Author
|
Contributor
Reviewer's GuideAdds an API test ensuring composite content views with auto-publish and 'Always update to latest' components only update once on incremental child CV updates with --propagate-all-composites, and still auto-publish on subsequent major CV publication, verifying SAT-34620 behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider splitting this test into two focused tests (one for incremental update with
--propagate-all-compositesand one for auto-publish on major version) to improve clarity of the behavior under test and make failures easier to diagnose. - You repeatedly compute sets/lists of
v.read().version; extracting this into a small helper (e.g.get_versions(cv_or_ccv)) would reduce duplication and make the assertions more readable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider splitting this test into two focused tests (one for incremental update with `--propagate-all-composites` and one for auto-publish on major version) to improve clarity of the behavior under test and make failures easier to diagnose.
- You repeatedly compute sets/lists of `v.read().version`; extracting this into a small helper (e.g. `get_versions(cv_or_ccv)`) would reduce duplication and make the assertions more readable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Collaborator
Author
|
PRT Result |
Satellite-QE
deleted the
cherry-pick-6.19.z-5ca9326122ab0f55c6927f1a35cfe9f9247f0f26
branch
February 24, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #20814
Problem Statement
When publishing a minor version of a content view, parent composite content views no longer respect the
--propagate-all-compositesflag.https://issues.redhat.com/browse/SAT-34620
Solution
Newly added test case will verify the incremental update on the CV with the
--propagate-all-compositesflagRelated Issues
N/A
PRT test Cases example
Summary by Sourcery
Tests: