[6.19.z] adjusted asserts for mcp user tests

[Satellite-QE]

Cherrypick of PR: #20852

Problem Statement

targeting an issue that isn't reproducible outside of our regular automation runs, therefore a bit mysterious. My hypothesis is that on the first run attempt the mcp client queries the mcp server before the connection with satellite is established using custom credentials.

Solution

Allow for a second try if the aforementioned issue happens

Related Issues

Summary by Sourcery

Relax flaky MCP user view permissions test behavior around transient connection failures and strengthen negative access assertion.

Tests:

• Add a retry in the MCP user view permissions test when a transient 'Max retries exceeded' error is returned from the API call.
• Assert the MCP client returns an 'Access denied' error message for disallowed resources in the negative permission path.

[Satellite-QE]

trigger: test-robottelo
pytest: tests/foreman/sys/test_mcp.py::test_positive_mcp_user_view_permissions

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the MCP user permissions system test to tolerate a transient connection error by retrying once and strengthens the negative-permission assertion to validate the exact access-denied error payload.

File-Level Changes

Change	Details	Files
Make the MCP user view-permissions test resilient to a transient "Max retries exceeded" error and tighten the assertion for denied resource access.	After the initial MCP client call to the Foreman API, detect a specific transient error condition in the result payload and perform a single retry of the same request. After verifying that access to the denied resource fails, add an assertion that the response payload contains the expected "Access denied" error message in the nested error structure.	tests/foreman/sys/test_mcp.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The retry logic based on a specific error message string is quite brittle; consider checking for a more structured error signal (e.g., status code/exception type) or wrapping this in a small helper so similar transient cases can be handled consistently across tests.
• The new assertion result.data['response']['error']['message'] assumes a deeply nested structure that may not always exist; you might want to guard this with safer access (e.g., get or an explicit assertion on the response shape) to avoid unexpected KeyErrors masking the test intent.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The retry logic based on a specific error message string is quite brittle; consider checking for a more structured error signal (e.g., status code/exception type) or wrapping this in a small helper so similar transient cases can be handled consistently across tests.
- The new assertion `result.data['response']['error']['message']` assumes a deeply nested structure that may not always exist; you might want to guard this with safer access (e.g., `get` or an explicit assertion on the response shape) to avoid unexpected KeyErrors masking the test intent.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/sys/test_mcp.py::test_positive_mcp_user_view_permissions

[Satellite-QE]

PRT Result

Build Number: 14468
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/sys/test_mcp.py::test_positive_mcp_user_view_permissions --external-logging
Test Result : ================== 4 passed, 40 warnings in 828.89s (0:13:48) ==================