[6.19.z] set the logout redirect setting within the test body

[Satellite-QE]

Cherrypick of PR: #20824

Problem Statement

continuation from #20718, it seems that other test tend to override the global setting for the altered test, so it passes when run in isolation but not in batch session in with other tests -- edit: the issue was actually in fixture precedence

Solution

setting is now changed in test body

Related Issues

Summary by Sourcery

Tests:

• Mark the LDAP logout redirect test to run in a single thread to avoid concurrency-related interference.

Summary by Sourcery

Tests:

• Adjust the RH-SSO single sign-on LDAP test to set the login_delegation_logout_url setting in the test body and clean it up to avoid cross-test interference.

[Satellite-QE]

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the RH-SSO single sign-on LDAP test to manage the logout redirect setting within the test body instead of via a parametrized fixture, ensuring isolation and proper cleanup of the global setting.

File-Level Changes

Change	Details	Files
Manage the login_delegation_logout_url setting inside the RH-SSO SSO test for better isolation and cleanup.	Remove parametrization over a setting_update fixture for configuring the logout redirect URL. Update the test signature to drop the now-unused setting_update parameter. Fetch the login_delegation_logout_url Setting object via the API at runtime and capture its prior value. Set the setting to LOGIN_DELEGATION_LOGOUT_URL before performing logout and redirect assertions. Wrap the logout and assertion logic in a try/finally to restore the original setting value after the test completes.	tests/foreman/destructive/test_ldap_authentication.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• When fetching the login_delegation_logout_url setting, consider handling the case where search(...)[0] returns an empty list (e.g., by asserting the result is non-empty or raising a clear error) to avoid a bare IndexError if the setting is missing or renamed.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When fetching the `login_delegation_logout_url` setting, consider handling the case where `search(...)[0]` returns an empty list (e.g., by asserting the result is non-empty or raising a clear error) to avoid a bare `IndexError` if the setting is missing or renamed.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso

[Satellite-QE]

PRT Result

Build Number: 14480
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso --external-logging
Test Result : ========== 1 passed, 28 deselected, 10 warnings in 1843.61s (0:30:43) ==========