Skip to content

[6.18.z] Fix parametrization order for MCP server test - #20884

Merged
Satellite-QE merged 1 commit into
6.18.zfrom
cherry-pick-6.18.z-cae1f16380c3b423708b5e514befcfb2940433f7
Feb 26, 2026
Merged

[6.18.z] Fix parametrization order for MCP server test#20884
Satellite-QE merged 1 commit into
6.18.zfrom
cherry-pick-6.18.z-cae1f16380c3b423708b5e514befcfb2940433f7

Conversation

@Satellite-QE

@Satellite-QE Satellite-QE commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Cherrypick of PR: #20883

Problem Statement

Incorrect parametrization order for MCP server test:

  • running downstream parameter tests Stage
  • running stage parameter tests Prod

Solution

Fix parametrization order

Related Issues

SAT-42137

Summary by Sourcery

Bug Fixes:

  • Fix mismatched parametrization IDs so the MCP server test runs the correct environment (stage vs downstream) for each parameter.

@Satellite-QE Satellite-QE added 6.18.z Introduced in or relating directly to Satellite 6.18 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 26, 2026
@Satellite-QE

Copy link
Copy Markdown
Collaborator Author

trigger: test-robottelo
pytest: -v tests/foreman/sys/test_mcp.py::test_positive_call_mcp_server

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 26, 2026
@Satellite-QE

Copy link
Copy Markdown
Collaborator Author

PRT Result

Build Number: 14490
Build Status: SUCCESS
PRT Comment: pytest -v tests/foreman/sys/test_mcp.py::test_positive_call_mcp_server --external-logging
Test Result : ================= 3 passed, 63 warnings in 1369.68s (0:22:49) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2026
@Satellite-QE
Satellite-QE merged commit 22df1f4 into 6.18.z Feb 26, 2026
21 of 22 checks passed
@Satellite-QE
Satellite-QE deleted the cherry-pick-6.18.z-cae1f16380c3b423708b5e514befcfb2940433f7 branch February 26, 2026 09:43
@sourcery-ai

sourcery-ai Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the pytest parametrization IDs for the MCP server test so that the logical environment names (upstream, stage, downstream) correctly match the parametrized targets and thus run against the intended environments.

File-Level Changes

Change Details Files
Correct mapping between MCP parametrized targets and their pytest IDs to ensure tests execute against the proper environments.
  • Update the order of pytest parametrization IDs to match the order of MCP target parameters
  • Ensure that the 'stage' and 'downstream' test cases are labeled correctly in parametrized execution
tests/foreman/sys/test_mcp.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.18.z Introduced in or relating directly to Satellite 6.18 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants