[6.19.z] Automation for SAT-32425 - #20895
Merged
vsedmik merged 1 commit intoFeb 26, 2026
Merged
Conversation
Contributor
Reviewer's GuideAdds a new UI test to verify that only a single 'Library' lifecycle environment option is shown in the Create Host form when organization is set and location is set to 'Any location'. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The assertion
filter_content.read().count('Library') == 1is fairly brittle; consider asserting against the actual LCE option elements (or a more specific locator) instead of a raw text count to avoid false positives from other occurrences of the word "Library". - After
open_filter.click(), it may be safer to wait for the LCE options to be visible/loaded (e.g., via an explicit wait on a specific element) before readingfilter_contentto reduce flakiness.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The assertion `filter_content.read().count('Library') == 1` is fairly brittle; consider asserting against the actual LCE option elements (or a more specific locator) instead of a raw text count to avoid false positives from other occurrences of the word "Library".
- After `open_filter.click()`, it may be safer to wait for the LCE options to be visible/loaded (e.g., via an explicit wait on a specific element) before reading `filter_content` to reduce flakiness.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
|
PRT Result |
vsedmik
approved these changes
Feb 26, 2026
vsedmik
enabled auto-merge (squash)
February 26, 2026 13:05
vsedmik
force-pushed
the
619AutomationSAT-32425
branch
from
February 26, 2026 13:06
ca20514 to
4cd1a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual CP of #20888
Needs: SatelliteQE/airgun#2324
Summary by Sourcery
Tests: