[6.17.z] SAT-20386 Jira card is closed; removing it.

[Satellite-QE]

Cherrypick of PR: #20839

The host is enabled with FIPS mode, so card SAT-20386 is being removed as the condition is no longer required.

Summary by Sourcery

Update FIPS-enabled RHEL PXE provisioning test expectations and skip conditions for known issues.

Bug Fixes:

• Ensure the FIPS-enabled RHEL PXE provisioning test always expects FIPS to be enabled on provisioned hosts rather than conditionally based on SAT-20386.

Tests:

• Add a conditional skip in the RHEL PXE provisioning FIPS test for RHEL 7 UEFI cases affected by the known issue SAT-41340.

[Satellite-QE]

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the RHEL PXE FIPS provisioning test to unconditionally require FIPS on provisioned hosts and adds a targeted skip for a known RHEL7+UEFI issue, removing the now-obsolete SAT-20386 conditional behavior.

File-Level Changes

Change	Details	Files
Tighten FIPS expectation in the RHEL PXE provisioning test by removing dependency on the SAT-20386 Jira flag.	Replace conditional FIPS-enabled assertion using is_open('SAT-20386') with an unconditional check that /proc/sys/crypto/fips_enabled equals 1 Ensure the test always fails when FIPS is not enabled on the provisioned host, regardless of Jira issue state	tests/foreman/api/test_provisioning.py
Introduce a targeted skip in the RHEL PXE FIPS provisioning test for a known RHEL7 UEFI issue tracked by SAT-41340.	Add a precondition that checks is_open('SAT-41340'), UEFI firmware, and RHEL major version 7 before running the test Invoke pytest.skip with a clear message when the known-issue conditions are met to avoid false negatives in affected environments	tests/foreman/api/test_provisioning.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In the new skip condition, pxe_loader.vm_firmware in ['uefi'] can be simplified to a direct equality check (pxe_loader.vm_firmware == 'uefi') for clarity.
• When asserting on int(result.stdout), consider stripping whitespace (int(result.stdout.strip())) to avoid brittle failures if the command output includes trailing newlines or spaces.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the new skip condition, `pxe_loader.vm_firmware in ['uefi']` can be simplified to a direct equality check (`pxe_loader.vm_firmware == 'uefi'`) for clarity.
- When asserting on `int(result.stdout)`, consider stripping whitespace (`int(result.stdout.strip())`) to avoid brittle failures if the command output includes trailing newlines or spaces.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

This pull request has not been updated in the past 45 days.

[github-actions]

This pull request is now being closed after stale warnings.