[6.18.z] SAT-20386 Jira card is closed; removing it.

[Satellite-QE]

Cherrypick of PR: #20839

The host is enabled with FIPS mode, so card SAT-20386 is being removed as the condition is no longer required.

Summary by Sourcery

Update RHEL PXE provisioning FIPS-enabled test expectations and skip conditions for known issues.

Bug Fixes:

• Ensure the FIPS-enabled provisioning test consistently expects FIPS to be enabled on provisioned hosts instead of conditionally allowing it to be disabled.

Tests:

• Skip RHEL 7 UEFI FIPS-enabled provisioning scenario when a known issue (SAT-41340) is still open to avoid invalid test failures.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the RHEL PXE FIPS provisioning test to always require FIPS to be enabled and adds a conditional skip for a known RHEL7/UEFI issue, removing the now-obsolete SAT-20386-based conditional behavior.

File-Level Changes

Change	Details	Files
Tighten FIPS expectations and add conditional skip in the RHEL PXE provisioning test for specific RHEL7/UEFI conditions.	Introduce a conditional pytest.skip when SAT-41340 is open and the test target is RHEL 7 with UEFI firmware, to avoid running a known-broken scenario. Simplify the FIPS assertion to always require /proc/sys/crypto/fips_enabled to be 1, removing the SAT-20386 gating logic.	tests/foreman/api/test_provisioning.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The skip condition for the RHEL7 UEFI case could be made more robust by comparing os.major as an integer (or via a small helper) instead of the string literal '7', to avoid subtle type issues if os.major changes type in the future.
• Since pxe_loader.vm_firmware is only being compared against a single value, == 'uefi' is clearer than in ['uefi'] and avoids implying support for multiple firmware values that are not handled.
• Consider adding a brief reference to SAT-41340 in the pytest.skip message itself (e.g., including the ticket ID) to make it easier to trace why the test is being skipped when reading test output alone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The skip condition for the RHEL7 UEFI case could be made more robust by comparing `os.major` as an integer (or via a small helper) instead of the string literal `'7'`, to avoid subtle type issues if `os.major` changes type in the future.
- Since `pxe_loader.vm_firmware` is only being compared against a single value, `== 'uefi'` is clearer than `in ['uefi']` and avoids implying support for multiple firmware values that are not handled.
- Consider adding a brief reference to SAT-41340 in the `pytest.skip` message itself (e.g., including the ticket ID) to make it easier to trace why the test is being skipped when reading test output alone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 14584
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : =========== 7 failed, 1 skipped, 531 warnings in 9537.71s (2:38:57) ============

[github-actions]

This pull request has not been updated in the past 45 days.

[github-actions]

This pull request is now being closed after stale warnings.