[6.19.z] SAT-20386 Jira card is closed; removing it.

[Satellite-QE]

Cherrypick of PR: #20839

The host is enabled with FIPS mode, so card SAT-20386 is being removed as the condition is no longer required.

Summary by Sourcery

Enforce FIPS being enabled after RHEL PXE provisioning and introduce a conditional skip for the known-broken RHEL7 UEFI scenario.

Bug Fixes:

• Always require FIPS to be enabled on provisioned hosts instead of conditionally allowing it to be disabled based on SAT-20386.
• Skip the RHEL7 UEFI PXE provisioning test when affected by the known SAT-41340 issue to avoid unstable failures.

Tests:

• Adjust the RHEL PXE provisioning FIPS test to assert FIPS is enabled unconditionally and to skip the RHEL7 UEFI case when a related known issue is open.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the RHEL PXE FIPS provisioning test to always expect FIPS to be enabled and introduces a conditional skip for a known RHEL7 UEFI issue, removing the now-obsolete SAT-20386 condition.

File-Level Changes

Change	Details	Files
Strengthen FIPS expectation and add conditional skip for known RHEL7 UEFI issue in the RHEL PXE provisioning test.	Introduce a conditional pytest.skip when SAT-41340 is open, firmware is UEFI, and OS major version is 7 to avoid running the unsupported scenario. Simplify the FIPS-enabled assertion to always require /proc/sys/crypto/fips_enabled to be 1, removing the SAT-20386-based conditional.	tests/foreman/api/test_provisioning.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The firmware check pxe_loader.vm_firmware in ['uefi'] can be simplified to a direct equality comparison (== 'uefi') for clarity and to avoid suggesting multiple supported values.
• Consider extracting a small helper (e.g., skip_if_issue_open('SAT-41340', condition, reason)) to encapsulate the is_open(...) + pytest.skip(...) pattern if this is or will be reused across other tests.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The firmware check `pxe_loader.vm_firmware in ['uefi']` can be simplified to a direct equality comparison (`== 'uefi'`) for clarity and to avoid suggesting multiple supported values.
- Consider extracting a small helper (e.g., `skip_if_issue_open('SAT-41340', condition, reason)`) to encapsulate the `is_open(...)` + `pytest.skip(...)` pattern if this is or will be reused across other tests.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Satellite-QE]

PRT Result

Build Number: 14587
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : ====== 2 failed, 5 passed, 1 skipped, 541 warnings in 14682.36s (4:04:42) ======

[LadislavVasina1]

ack, waiting for PRT to pass

[Satellite-QE]

PRT Result

Build Number: 14595
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : ====== 2 failed, 5 passed, 1 skipped, 552 warnings in 14397.34s (3:59:57) ======

[Satellite-QE]

PRT Result

Build Number: 14631
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : = 1 failed, 4 passed, 1 skipped, 524 warnings, 3 errors in 11801.21s (3:16:41) =

[Satellite-QE]

PRT Result

Build Number: 14644
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : = 1 failed, 4 passed, 1 skipped, 528 warnings, 2 errors in 13569.71s (3:46:09) =

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 14656
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning_fips_enabled --external-logging --include-onprem-provisioning
Test Result : =========== 7 passed, 1 skipped, 572 warnings in 15103.90s (4:11:43) ===========