Verifies the Create, Read, Update, and Delete operations for the OCPV…

[amolpati30]

OCPV Compute Resource CRUD Operation verifies the Create, Read, Update, and Delete operations for the OCPV compute resource.
It ensures that the compute resource can be properly managed and validated through the system using UI interface.

Dependent: SatelliteQE/airgun#2327

Summary by Sourcery

Tests:

• Introduce an end-to-end test that validates create, read, update, and delete flows for the OCP-V compute resource including org/location assignments.

[sourcery-ai]

Reviewer's Guide

Adds an end-to-end UI test that verifies full CRUD (Create, Read, Update, Delete) behavior for the OpenShift Virtualization (OCP-V) compute resource, including provider configuration and organization/location assignments.

File-Level Changes

Change	Details	Files
Add an end-to-end CRUD UI test for OCP-V compute resources.	Introduce a pytest-marked e2e test that creates an OCP-V compute resource via the UI with provider and scoping settings. Verify the created compute resource fields (name, description, provider, hostname, api_port, namespace, orgs, locations) via a read operation. Update the compute resource by renaming it and assigning additional organization/location, then verify the merged assignments. Delete the compute resource and assert it can no longer be found via search.	tests/foreman/ui/test_computeresource_ocpv.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In the UPDATE step you pass only [new_org.name]/[new_loc.name] to organizations.resources.assigned and locations.resources.assigned but then assert that both the original and new org/location are assigned; if the UI/API behavior is to replace rather than merge, this test will be brittle—either explicitly include both in the payload or adjust the assertions to match the intended semantics.
• The test creates additional organizations/locations via module_ocpv_sat.api.Organization().create() and .Location().create() without any explicit cleanup, which can leave persistent test data behind; consider using a fixture or context that ensures these resources are deleted after the test.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the UPDATE step you pass only `[new_org.name]`/`[new_loc.name]` to `organizations.resources.assigned` and `locations.resources.assigned` but then assert that both the original and new org/location are assigned; if the UI/API behavior is to replace rather than merge, this test will be brittle—either explicitly include both in the payload or adjust the assertions to match the intended semantics.
- The test creates additional organizations/locations via `module_ocpv_sat.api.Organization().create()` and `.Location().create()` without any explicit cleanup, which can leave persistent test data behind; consider using a fixture or context that ensures these resources are deleted after the test.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_ocpv.py -k test_positive_cr_end_to_end
airgun: 2327

[Satellite-QE]

PRT Result

Build Number: 14667
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_ocpv.py -k test_positive_cr_end_to_end --external-logging
Test Result : =========== 1 passed, 1 deselected, 9 warnings in 1678.56s (0:27:58) ===========

[ShimShtein]

I am missing the "test connection" button here. I didn't see it being invoked in the airgun too.

[amolpati30]

We are not checking the test connection here, as it only ensures that the connection has been established correctly. Therefore, I did not use it while creating the compute resource.