[6.19.z] Move test_podman_login_check to destructive tests

[Satellite-QE]

Cherrypick of PR: #20849

Problem Statement

On an IoP-enabled Satellite, test_podman_login_check logs out of the container registry at the end of the test and uses a finalizer that also calls podman_logout. That leaves the host in a logged-out state. Other tests that run on the same host (e.g. test_positive_health_check_pre_upgrade when the “satellite” host is IoP) then run pre-upgrade health checks that include “Check whether podman needs to be logged in to the registry,” and those checks fail because podman is still logged out.

Solution

Move the test_podman_login_check to destructive so other test are successfully run

Related Issues

Summary by Sourcery

Bug Fixes:

• Fix podman login health check test finalizer so the host is left logged in to the registry instead of logged out, preventing failures in later tests that rely on a logged-in state.

Summary by Sourcery

Tests:

• Relocate test_podman_login_check from general foreman maintain health tests to foreman destructive health tests so its state changes are isolated from other scenarios.

[Satellite-QE]

trigger: test-robottelo
pytest: tests/foreman/ -n 4 --component SatelliteMaintain

[sourcery-ai]

Reviewer's Guide

Moves the IoP-specific podman login health check test from the generic maintain health test module into a new destructive health test module without changing its behavior, so that it no longer affects subsequent tests on the same host.

File-Level Changes

Change	Details	Files
Relocate the IoP podman login health check test into the destructive test suite while preserving its logic and fixtures.	Remove test_podman_login_check from the general satellite-maintain health test module Create a new destructive health test module that mirrors the existing module metadata and imports Reintroduce test_podman_login_check in the new destructive module with the same test body, markers, and finalizer behavior	tests/foreman/maintain/test_health.py tests/foreman/destructive/test_fm_health.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}