Skip to content

Remove selinux context test as its already covered in the unit test - #22236

Merged
shubhamsg199 merged 1 commit into
SatelliteQE:masterfrom
shubhamsg199:remove_selinux_context_test
Jul 23, 2026
Merged

Remove selinux context test as its already covered in the unit test#22236
shubhamsg199 merged 1 commit into
SatelliteQE:masterfrom
shubhamsg199:remove_selinux_context_test

Conversation

@shubhamsg199

@shubhamsg199 shubhamsg199 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Remove selinux context test as its already covered in the unit test -> theforeman/foremanctl#692

Summary by Sourcery

Tests:

  • Delete Apache SELinux context upgrade test case from installer test suite to avoid duplication with unit-level coverage.

@shubhamsg199 shubhamsg199 self-assigned this Jul 23, 2026
@shubhamsg199
shubhamsg199 requested a review from a team as a code owner July 23, 2026 09:59
@shubhamsg199 shubhamsg199 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 23, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request removes an Apache SELinux context integration test that is now redundant with existing unit test coverage in the installer test suite.

File-Level Changes

Change Details Files
Remove redundant Apache SELinux context integration test from the installer upgrade tests.
  • Delete pytest-marked upgrade test that validates SELinux httpd_config_t context on Apache module config files.
  • Remove Puppet-based creation and verification of a temporary SELinux test config file.
  • Simplify the installer test module by relying on existing unit tests for SELinux context coverage.
tests/foreman/installer/test_installer.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shubhamsg199
shubhamsg199 merged commit 2d6a4b5 into SatelliteQE:master Jul 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants