Skip to content

Refactor Memory Assertion for Libvirt - #22275

Merged
Gauravtalreja1 merged 1 commit into
SatelliteQE:masterfrom
amolpati30:Update_libvirt_memory_assertion
Jul 27, 2026
Merged

Refactor Memory Assertion for Libvirt#22275
Gauravtalreja1 merged 1 commit into
SatelliteQE:masterfrom
amolpati30:Update_libvirt_memory_assertion

Conversation

@amolpati30

@amolpati30 amolpati30 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

The assertion for the libvirt memory field was failing due to a UI change. I updated the assertion accordingly.

Summary by Sourcery

Bug Fixes:

  • Adjust libvirt memory assertions in UI tests to align with the updated format returned by the application.

@amolpati30
amolpati30 requested a review from a team as a code owner July 27, 2026 08:03
@amolpati30 amolpati30 added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 27, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the UI dropped the MB suffix, consider normalizing or parsing the memory value (e.g., comparing numeric values) rather than hardcoding the exact string format to make the tests more resilient to future display changes.
  • If other providers or tests assert on memory fields, it may be worth centralizing a helper for reading and comparing memory values so that similar UI-driven format changes only need to be updated in one place.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the UI dropped the `MB` suffix, consider normalizing or parsing the memory value (e.g., comparing numeric values) rather than hardcoding the exact string format to make the tests more resilient to future display changes.
- If other providers or tests assert on memory fields, it may be worth centralizing a helper for reading and comparing memory values so that similar UI-driven format changes only need to be updated in one place.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amolpati30

Copy link
Copy Markdown
Contributor Author
trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_libvirt.py -k 'test_positive_associate_with_custom_profile or test_positive_end_to_end'

@Satellite-QE

Copy link
Copy Markdown
Collaborator

PRT Result

Build Number: 16253
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_associate_with_custom_profile or test_positive_end_to_end --external-logging
Test Result : ========== 3 passed, 9 deselected, 40 warnings in 1933.44s (0:32:13) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 27, 2026
@Gauravtalreja1 Gauravtalreja1 added the TestFailure Issues and PRs related to a test failing in automation label Jul 27, 2026
@Gauravtalreja1
Gauravtalreja1 merged commit 11ba202 into SatelliteQE:master Jul 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants