Refactor Memory Assertion for Libvirt - #22275
Merged
Gauravtalreja1 merged 1 commit intoJul 27, 2026
Merged
Conversation
Contributor
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the UI dropped the
MBsuffix, consider normalizing or parsing the memory value (e.g., comparing numeric values) rather than hardcoding the exact string format to make the tests more resilient to future display changes. - If other providers or tests assert on memory fields, it may be worth centralizing a helper for reading and comparing memory values so that similar UI-driven format changes only need to be updated in one place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the UI dropped the `MB` suffix, consider normalizing or parsing the memory value (e.g., comparing numeric values) rather than hardcoding the exact string format to make the tests more resilient to future display changes.
- If other providers or tests assert on memory fields, it may be worth centralizing a helper for reading and comparing memory values so that similar UI-driven format changes only need to be updated in one place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
Collaborator
|
PRT Result |
arvind4501
approved these changes
Jul 27, 2026
Gauravtalreja1
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion for the libvirt memory field was failing due to a UI change. I updated the assertion accordingly.
Summary by Sourcery
Bug Fixes: