Move certificate bundle to auth bundle by arvind4501 · Pull Request #22277 · SatelliteQE/robottelo

arvind4501 · 2026-07-27T09:56:10Z

Problem Statement

theforeman/foremanctl#698 changes the old certificate bundle command and adds oauth/ credentials into the bundle

Solution

Change according to theforeman/foremanctl#698

Related Issues

Summary by Sourcery

Tests:

Adapt capsule bundle integration test from certificate-bundle to auth-bundle, including generation and renewal flows and expectations for OAuth credentials in the bundle contents.

sourcery-ai · 2026-07-27T09:56:17Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the foremanctl capsule bundle test to target the new auth-bundle command instead of certificate-bundle and validate that OAuth credentials are included in the bundle tarball in addition to existing certificate checks.

File-Level Changes

Change	Details	Files
Switch capsule bundle test flow from `certificate-bundle` to `auth-bundle` and adjust assertions and messaging accordingly.	Rename the main capsule bundle test from `test_positive_foremanctl_certificate_bundle` to `test_positive_foremanctl_auth_bundle` and update its docstring, steps, and expected results to reference auth bundles instead of certificate bundles. Change foremanctl invocations from `foremanctl certificate-bundle ...` to `foremanctl auth-bundle ...` for both initial bundle generation and renewal, including updating failure messages. Update assertion messages and comments to consistently refer to auth bundles rather than certificate bundles.	`tests/foreman/foremanctl/test_install_foremanctl.py`
Extend capsule bundle content validation to cover OAuth credentials in addition to existing certificate files.	Update the helper `foremanctl_capsule_cert_paths` docstring to describe auth bundles instead of certificate bundles. Change the tarball existence assertion message to reference an auth bundle tarball rather than a certificate bundle tarball. Add assertions that the tarball content listing includes `oauth/foreman-oauth-consumer-key` and `oauth/foreman-oauth-consumer-secret` while retaining existing certificate file assertions.	`tests/foreman/foremanctl/test_install_foremanctl.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've left some high level feedback:

Now that foremanctl_capsule_cert_paths also validates oauth files, consider renaming the helper (and/or its docstring/return values) to better reflect that it deals with the full auth bundle rather than only certificate paths, so future readers don’t assume it’s certificate-only.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that `foremanctl_capsule_cert_paths` also validates oauth files, consider renaming the helper (and/or its docstring/return values) to better reflect that it deals with the full auth bundle rather than only certificate paths, so future readers don’t assume it’s certificate-only.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

arvind4501 · 2026-07-27T11:13:54Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
  foremanctl: 698

Satellite-QE · 2026-07-27T12:52:02Z

PRT Result

Build Number: 16256
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 20 deselected, 24 warnings, 1 error in 5154.33s (1:25:54) ===========

arvind4501 · 2026-07-27T13:18:08Z


trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
  foremanctl: 698

Satellite-QE · 2026-07-27T14:22:21Z

PRT Result

Build Number: 16258
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 1 failed, 20 deselected, 15 warnings in 3110.34s (0:51:50) ==========

arvind4501 · 2026-07-27T14:38:46Z


trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
  foremanctl: 698

Satellite-QE · 2026-07-27T15:30:03Z

PRT Result

Build Number: 16262
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 1 failed, 20 deselected, 11 warnings in 2354.38s (0:39:14) ==========

Gauravtalreja1 · 2026-07-28T07:44:48Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
  foremanctl: 698

sourcery-ai

Hey - I've left some high level feedback:

Consider renaming foremanctl_capsule_cert_paths (and related variables like capsule_certs) to something like *_auth_bundle_paths to better reflect that the helper now validates OAuth files in addition to certificates.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider renaming `foremanctl_capsule_cert_paths` (and related variables like `capsule_certs`) to something like `*_auth_bundle_paths` to better reflect that the helper now validates OAuth files in addition to certificates.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Satellite-QE · 2026-07-28T08:34:28Z

PRT Result

Build Number: 16267
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 1 failed, 20 deselected, 11 warnings in 2304.02s (0:38:24) ==========

shubhamsg199 · 2026-07-28T09:48:36Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
theforeman:
  foremanctl: 698

shubhamsg199 · 2026-07-28T10:57:14Z

@arvind4501 Can you remove pytest.mark.foremanctl from the module level and rerun the PRT without deployment_type: container. In the current installer module framework we are manually installing the foremanctl on a RHEL box so it conflicts right now

arvind4501 · 2026-07-28T11:03:31Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
theforeman:
  foremanctl: 698

Satellite-QE · 2026-07-28T11:55:48Z

PRT Result

Build Number: 16271
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 1 failed, 20 deselected, 11 warnings in 2362.42s (0:39:22) ==========

arvind4501 · 2026-07-29T11:11:24Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
    foremanctl: 698

Satellite-QE · 2026-07-29T12:37:31Z

PRT Result

Build Number: 16284
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 20 deselected, 12 warnings, 1 error in 4570.57s (1:16:10) ===========

amolpati30 · 2026-07-30T07:09:04Z

 @pytest.mark.rhel_ver_match('9')
-def test_positive_foremanctl_certificate_bundle(module_sat_ready_rhel, rhel_contenthost):
-    """Verify foremanctl certificate-bundle generation and renewal for a capsule.
+def test_positive_foremanctl_auth_bundle(module_sat_ready_rhel, rhel_contenthost):


I would recommend using module_target_sat instead of module_sat_ready_rhel. There might be a conflict caused by using module_sat_ready_rhel, as it is created only when we don't have the setup available.

arvind4501 · 2026-07-30T10:24:32Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
  foremanctl: 698

arvind4501 · 2026-07-31T07:19:34Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle
deployment_type: container
theforeman:
  foremanctl: 698

Satellite-QE · 2026-07-31T08:48:50Z

PRT Result

Build Number: 16307
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py -k test_positive_foremanctl_auth_bundle --external-logging
Test Result : ========== 20 deselected, 12 warnings, 1 error in 4620.05s (1:17:00) ===========

arvind4501 requested a review from a team as a code owner July 27, 2026 09:56

github-actions Bot assigned arvind4501 Jul 27, 2026

arvind4501 mentioned this pull request Jul 27, 2026

transfer oauth creds as part of certificate bundle theforeman/foremanctl#698

Merged

2 tasks

sourcery-ai Bot reviewed Jul 27, 2026

View reviewed changes

arvind4501 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 27, 2026

arvind4501 marked this pull request as draft July 27, 2026 09:57

arvind4501 force-pushed the auth-bundle branch from 8415754 to 7bb924a Compare July 27, 2026 09:59

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 27, 2026

arvind4501 marked this pull request as ready for review July 28, 2026 08:08

arvind4501 marked this pull request as draft July 28, 2026 08:08

sourcery-ai Bot reviewed Jul 28, 2026

View reviewed changes

arvind4501 marked this pull request as ready for review July 28, 2026 08:14

arvind4501 force-pushed the auth-bundle branch from 7bb924a to 21d0d71 Compare July 28, 2026 11:03

amolpati30 reviewed Jul 30, 2026

View reviewed changes

arvind4501 requested a review from a team as a code owner July 30, 2026 10:22

arvind4501 force-pushed the auth-bundle branch from 8eeed1e to ca813a1 Compare July 30, 2026 10:24

arvind4501 force-pushed the auth-bundle branch 2 times, most recently from 20ff8d8 to 08f2ba2 Compare July 31, 2026 06:38

arvind4501 removed the request for review from a team July 31, 2026 06:38

Move certificate bundle to auth bundle

4570293

arvind4501 force-pushed the auth-bundle branch from 08f2ba2 to 4570293 Compare July 31, 2026 06:44

Uh oh!

Conversation

arvind4501 commented Jul 27, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Solution

Related Issues

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

arvind4501 commented Jul 27, 2026

Uh oh!

Satellite-QE commented Jul 27, 2026

Uh oh!

arvind4501 commented Jul 27, 2026

Uh oh!

Satellite-QE commented Jul 27, 2026

Uh oh!

arvind4501 commented Jul 27, 2026

Uh oh!

Satellite-QE commented Jul 27, 2026

Uh oh!

Gauravtalreja1 commented Jul 28, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Satellite-QE commented Jul 28, 2026

Uh oh!

shubhamsg199 commented Jul 28, 2026

Uh oh!

shubhamsg199 commented Jul 28, 2026

Uh oh!

arvind4501 commented Jul 28, 2026

Uh oh!

Satellite-QE commented Jul 28, 2026

Uh oh!

arvind4501 commented Jul 29, 2026

Uh oh!

Satellite-QE commented Jul 29, 2026

Uh oh!

amolpati30 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

arvind4501 commented Jul 30, 2026

Uh oh!

arvind4501 commented Jul 31, 2026

Uh oh!

Satellite-QE commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arvind4501 commented Jul 27, 2026 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Jul 27, 2026 •

edited

Loading