Skip to content

Remove Cloud Connector API/CLI Related code - #22315

Open
LadislavVasina1 wants to merge 2 commits into
SatelliteQE:masterfrom
LadislavVasina1:removeCloudConnectorCliTest
Open

Remove Cloud Connector API/CLI Related code#22315
LadislavVasina1 wants to merge 2 commits into
SatelliteQE:masterfrom
LadislavVasina1:removeCloudConnectorCliTest

Conversation

@LadislavVasina1

@LadislavVasina1 LadislavVasina1 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

As SAT-45983(Remove configure cloud connector from Api/Cli) is now complete, remove the leftover cloud connector code.

@LadislavVasina1 LadislavVasina1 self-assigned this Jul 31, 2026
@LadislavVasina1
LadislavVasina1 requested a review from a team as a code owner July 31, 2026 08:40
@sourcery-ai

sourcery-ai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the final cloud connector CLI test from the rhcloud inventory test suite, aligning the tests with the completion of SAT-45983.

File-Level Changes

Change Details Files
Remove the obsolete cloud connector enable CLI test from the rhcloud inventory test suite.
  • Delete the test_positive_cloud_connector_enable_cli test function and its associated docstring and assertions.
  • Retain surrounding tests (e.g., sync inventory status and max_org_size_variable) to preserve the existing test structure.
tests/foreman/cli/test_rhcloud_inventory.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If this was the last cloud connector test, consider searching for and removing any remaining cloud-connector-specific helpers, fixtures, or CLI wrappers that are now unused to keep the test suite and related code lean.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If this was the last cloud connector test, consider searching for and removing any remaining cloud-connector-specific helpers, fixtures, or CLI wrappers that are now unused to keep the test suite and related code lean.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LadislavVasina1 LadislavVasina1 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 31, 2026
@LadislavVasina1
LadislavVasina1 requested a review from a team as a code owner July 31, 2026 08:51
@LadislavVasina1 LadislavVasina1 changed the title Remove Cloud Connector CLI Test Remove Cloud Connector API/CLI Related code Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants