Skip to content

Adding -n to replace -d#165

Open
n0tthetree wants to merge 1 commit into
SathyaBhat:masterfrom
n0tthetree:bug1
Open

Adding -n to replace -d#165
n0tthetree wants to merge 1 commit into
SathyaBhat:masterfrom
n0tthetree:bug1

Conversation

@n0tthetree

Copy link
Copy Markdown

-d is nonfunctional (defaults to True AND toggles to True when passed in CLI)
adding -n to archieve the wanted toggle-functionality

@SathyaBhat

Copy link
Copy Markdown
Owner

I think instead of adding another new flag we could just fix the existing one

@n0tthetree

Copy link
Copy Markdown
Author

Sure thing, I just didnt want to destroy any scripts someone has made on the assumption that it downloads both with and without the flag given...
Thats why I wanted an opt-out for the download function.

@n0tthetree

Copy link
Copy Markdown
Author

If you want -d to work as an opt-in to downloading, tell me and I'm just remove default=True in the definition and send a new merge req.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants