Skip to content

BREAKING CHANGE: add option to hide exchange features for restricted regions#1345

Open
kwsantiago wants to merge 1 commit into
SatoshiPortal:developfrom
kwsantiago:1340-option-to-disable-exchange-features
Open

BREAKING CHANGE: add option to hide exchange features for restricted regions#1345
kwsantiago wants to merge 1 commit into
SatoshiPortal:developfrom
kwsantiago:1340-option-to-disable-exchange-features

Conversation

@kwsantiago
Copy link
Copy Markdown

Summary

  • Adds setting to hide exchange UI elements (buy, sell, pay, exchange)
  • Useful for users in regions where exchange features are unavailable
  • Reduces screen clutter when exchange functionality is not accessible

Changes

  • New hideExchangeFeatures setting in settings entity/repository/datasource
  • Toggle switch in app settings screen
  • Conditionally hide exchange action cards and menu items based on setting
  • Database migration to add setting column with default false

Closes #1340

@ethicnology ethicnology changed the title feat: add option to hide exchange features for restricted regions BREAKING CHANGE: add option to hide exchange features for restricted regions Oct 20, 2025
@ethicnology
Copy link
Copy Markdown
Member

ethicnology commented Oct 20, 2025

This PR once merged will require a new schema version, migrations and migrations tests, applying BREAKING CHANGES flag to warn maintainers during integration

@i5hi
Copy link
Copy Markdown
Collaborator

i5hi commented Nov 3, 2025

Nice work on following the architecture.

Once UI decision we have to make is what to do with Swaps/Transfers - its the only button on the centred action button list that isnt related to the exchange and looks awkward on its own.

We will have a discussion about this internally and update.

@basantagoswami
Copy link
Copy Markdown
Contributor

basantagoswami commented Nov 7, 2025

image

maybe we can follow this pattern for the swap button on wallet homescreen. taken from the layerz wallet. maybe put the swap button on the left, which would make it easier for people to click on both send and receive using their right thumb

@basantagoswami
Copy link
Copy Markdown
Contributor

I know the PR is outdated now and needs to be rebased, but a few feedback after running the branch in local (haven't checked the code):

  • When you hide the bottom nav bar, the The "Receive" and "Send" buttons end up flush against the bottom edge with no
    padding/margin
  • The transfer button needs to be moved elsewhere, maybe to the left of the buttons on the bottom, like I mentioned earlier
  • After the button is moved, make sure there is no card/layout sticking up into the pattern above

@kwsantiago kwsantiago force-pushed the 1340-option-to-disable-exchange-features branch 4 times, most recently from 317fb6e to 0d96a5b Compare November 25, 2025 20:57
@kwsantiago
Copy link
Copy Markdown
Author

Comments should be addressed in 0d96a5b

@kwsantiago kwsantiago force-pushed the 1340-option-to-disable-exchange-features branch from 0d96a5b to c4eebfc Compare November 26, 2025 20:20
@kwsantiago kwsantiago force-pushed the 1340-option-to-disable-exchange-features branch 2 times, most recently from 252b372 to 47d172c Compare December 4, 2025 00:01
@kwsantiago kwsantiago force-pushed the 1340-option-to-disable-exchange-features branch from 47d172c to b33a84a Compare December 4, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

option to disable exchange features

4 participants