Autoswap dynamic values + new seeds for placeholder#1726
Draft
BullishNode wants to merge 2 commits into
Draft
Conversation
- Display actual user-configured values in autoswap warning instead of hardcoded strings - Update database seeds to match model defaults (1M/2M instead of 500k/1M) - Read values from WalletBloc state and convert to BTC for display
…updates - Display values in BTC or sats based on user bitcoinUnit setting - Use FormatAmount for consistent formatting matching currency_text pattern - Trigger WalletRefreshed on settings save to reload values in WalletBloc - Apply BlocListener pattern in settings screen and bottom sheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database seeds update (1M/2M sats for new users): they were still 500,000 sats and 1,000,000 sats. @i5hi I don't know what to do about migration. Not sure we should migrate but if we do it would be only for people that are still on default configs.
Dynamic values that read from actual settings (the bottom sheet values were hardcoded)
Unit preference respect (BTC vs sats): bottom sheet values were in BTC whereas the actual amounts are in sats
Reactive updates when settings change
NOT MERGE READY, NOT REVIEWED