Early Review: Settings re-arch#1861
Open
kumulynja wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a re-arch of the current
settingsfeature that has code split betweencoreandfeaturesand that doesn't have a clear API for other features to use and so different features import different layers of the current settings code which leads to dependency problems.The current settings feature also doesn't have a clear distinction between general, app-wide settings (
AppSettings) and settings for specific features or capabilities like Tor or Error Reporting. This leads to the Settings feature needing to know how to initialise Tor or how to get the Tor proxy port or how to initialise Sentry for example. Those things and their settings should move to their own features/capabilities. Since this PR focuses on the general App Settings, we will keep Tor and Error reporting settings in the current settings feature still, while migrating all general app settings to a newly defined domain that keeps things simple and limited to managing basic app settings which are simple to set and retrieve.How to test: