Live components generic view#264
Closed
CallumVass wants to merge 2 commits intoSaturnFramework:liveComponentsfrom
CallumVass:liveComponents-genericView
Closed
Live components generic view#264CallumVass wants to merge 2 commits intoSaturnFramework:liveComponentsfrom CallumVass:liveComponents-genericView
CallumVass wants to merge 2 commits intoSaturnFramework:liveComponentsfrom
CallumVass:liveComponents-genericView
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Following Zaid's comment here: #247 (comment) I have implemented a possible solution to remove the dependency of XmlNode from the View of a LiveComponent. This will allow a user to use any ViewEngine and renderer to render that View as a string.
I was torn between creating another custom operation or making the existing
viewcustom operation for the CE accept a tuple which is a view and its associated renderer.Additionally I fixed some minor typo's
Feedback appreciated. Thanks for making a start on liveComponents, it looks promising! :)