Test suite - #1
Merged
Merged
Conversation
MandaloreUltimate
force-pushed
the
feature/test-suite
branch
from
June 25, 2025 15:20
d9de4eb to
ac310c5
Compare
elwer
reviewed
Jun 30, 2025
elwer
left a comment
elwer
left a comment
Collaborator
There was a problem hiding this comment.
looks good, just check for the memory thing please
Comment on lines
+94
to
+97
| mem_util = ( | ||
| psutil.virtual_memory().total - psutil.virtual_memory().available | ||
| ) / (1024**3) | ||
|
|
Collaborator
There was a problem hiding this comment.
shouldn't this refer to the identified memory limits (Slurm aware)?
Having the absolute number would also be beneficial but I guess this is something for the visualization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automated test suite, fix formatting issues in the code