Fix imports/exports from local sibling modules

[steinybot]

Fixes #638

Consider the following structure:

- a/index.d.ts
- b/index.d.ts
- package.json

Where package.json has:

  "types": "b/index.d.ts",

and b/index.d.ts has:

export * from '../a';

Currently this would not generate any of the types from b.

It seems it was intentional to only consider files from types and typings, or the module but this causes lookups from sibling modules to fail.

[steinybot]

I don't like how it does this. Since they are re-exported from the main module they should be there instead / as well. My previous attempt added the files to shortenedFiles which did the right thing in that regards but it messed up other stuff. That is probably a separate issue and would change a lot of the way things are generated whereas this change seems relatively isolated.

[steinybot]

There might be something not right here. It's getting confused between es and lib. For example:

[error]  found   : web.typings.antd.esButtonButtonMod.ButtonProps with web.typings.react.mod.RefAttributes[org.scalajs.dom.HTMLElement]
[error]  required: web.typings.antd.libButtonButtonMod.ButtonProps with web.typings.react.mod.RefAttributes[org.scalajs.dom.HTMLElement]

[steinybot]

Ok I think that's fixed now. The problem was that it was adding a ModuleAliases from es to lib which was overwriting and/or higher priority than the normal module scope.

[steinybot]

Interestingly this fixes another existing bug which is the opposite to the problem I had above.

@ant-design/icons/es/components/AntdIcon.d.ts has this import:

import type { IconDefinition } from '@ant-design/icons-svg/lib/types';

Which used to incorrectly resolve to antDesignIconsSvg.esTypesMod.IconDefinition but now it correctly resolves to antDesignIconsSvg.libTypesMod.IconDefinition.

[steinybot]

Ughhh so the main entry wasn't being handled properly either (see zootools test).

I have no idea why fixing that triggered a whole lot of changes in the react-integration-tests. Seems like it is all new stuff which is good in a way but the Readonly etc stuff seems odd. Is that supposed to be special cased somewhere?

[steinybot]

The real package uses es typings.

[steinybot]

Where is this coming from?

[steinybot]

Where did this go?

[steinybot]

Why dropped all of a sudden?

[steinybot]

Why does the error look whack? Seems like a double error or something.

[steinybot]

The PhaseRunner is now running Phase1ReadTypescript twice on react for some reason and so isCircular ends up true and it inserts Ignore into the PhaseCache so it ends up being missing from the moduleScopes. I have no idea how this is supposed to work...