Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a set of types for working with Javascript types which can be
null
/undefined
.In particular, we want to use inheritance to enable us to model the following narrowing of optionality in subtypes. This compiles in Typescript under
--strictNullChecks
:Using the type hierarchy in this PR we can express this in Scala.js like this:
js.undefined.asInstanceOf[X]
on rhs in@ScalaJSDefined
traits.D
s, it's impossible to tell scalac thata
is not implemented anymore. OTOH consuming this structure coming from javascript is straightforward with a safed.a.get