Fix Follow page auto-toggle (#51) and every-other scope order (#84) - #115
Merged
vigri merged 8 commits intoApr 20, 2026
Merged
Conversation
…anced#51) Removing the unconditional focusButton->setChecked(true) from goToPage() aligns keyboard navigation with mouse thumbnail selection. Batch processing and similar flows still set Follow page explicitly where intended.
…-Advanced#84) - Add PageSequence::selectThisPageAndFollowingEveryOther for "this page and the following every other page" in thumbnail order. - Add selectEveryOtherInSubsetFromPage for deskew/split "every other selected" (std::set iteration was not document order). - Use these in deskew, page layout, margins, fix orientation, split, select content.
This was referenced Apr 13, 2026
…heck - Replace unavailable libtiff5 with libtiff-dev stack (align with ci.yml). - Run clang-format-check only on changed src/ files like Lint workflow. - README: clarify Releases vs Flatpak manifest; link scantailor-testing (ScanTailor-Advanced#43).
Author
CI fixes in this branch (for reviewers)Summary of what changed in workflows / packaging so Actions stays green on current Ubuntu:
Feature work for #51 / #84 and discussion for the larger deskew/oblique split remain as in #114 / #117; this PR bundles the above CI/desktop fixes so merges are not blocked by failing workflows. |
Author
vigri
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#51 Follow page (eye / focus button)
goToPage()no longer forcesfocusButtonchecked; keyboard navigation matches mouse thumbnail selection.startBatchProcessing), and any other call sites that setfocusButton->setChecked(true)directly (unchanged).#84 "This page and the following every other page"
PageSequence::selectThisPageAndFollowingEveryOtherfor document/thumbnail order (same logic as Select Content had inline).selectEveryOtherInSubsetFromPagefor every other selected in deskew and split (fixesstd::setiteration order).Manual test suggestions
Fixes #51
Fixes #84