fix(deskew): oblique default and handle alignment (#145 follow-up) - #155
Open
pablogventura wants to merge 1 commit into
Open
fix(deskew): oblique default and handle alignment (#145 follow-up)#155pablogventura wants to merge 1 commit into
pablogventura wants to merge 1 commit into
Conversation
…ailor-Advanced#145) buildDefaultParams() always seeded oblique MODE_AUTO, so new pages ran auto oblique even when Automatic oblique correction was off. Auto deskew recompute also read prior per-page oblique mode instead of the global default. Anchor deskew/oblique overlay handles to the occupied image rect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #153 / v1.2.1 for the regression @zvezdochiot reported on #145 (screenshots on 1.2.1 @
5eaac18):Utils::buildDefaultParams()always seeded per-page oblique as Auto, so the first auto-deskew pass treated oblique as enabled.Task.cppalso reused prior per-page oblique mode during recompute instead of the Automatic oblique correction default / pending flag.Changes
Utils.cpp: default page oblique mode followsDefaultParams::isAutoOblique()(Manual when off).Task.cpp: auto oblique during recompute uses pending flag → global default only; preserve manual oblique angle only when prior oblique mode was Manual.ImageView.cpp: rotation/oblique origin and arc placement usegetOccupiedWidgetRect().Related #145. Does not close the longer-term ParamsDeskew/ParamsOblique refactor.
Test plan
ctest— 5/5 greenNot for merge until @zvezdochiot confirms on this branch (or reports remaining issues).