Update exist-db package #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(expath): add max supported version feat(expath): breaking change bump requirement just for testing, will likely need another 5.0.0 bump fix(expath): set semver max
ignore(xpr): ignore and add oxygen project
ci(travis): check test-results ci(travis): ensure proper xar is tested ci(travis): disable v5 and up, add v3 for testing
make paths dry adjust tests to new paths
|
@vincentml, do you have time to look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This is a breaking change !!
I am still looking into why the library can't be used in exist v5 and up, but i strongly suspect some bugs in exist. In the meantime I would recommend publishing an updated package that is tests and runs in exist v3 and v4.
this PR includes a number of functional updates:
ant testwith a running instance with empty admin password, and the library installed..xarto GitHUb releases. Simple create and push a tag to GitHub. I use my ownGH_Tokento publish it here, this would need to be adjusted.Some typos were fixed, the readme made prettier, and code was refactored to be more inline with exist-db community conventions.